Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stricter linters #672

Closed
yurishkuro opened this issue Mar 20, 2020 · 0 comments · Fixed by #738
Closed

Adding stricter linters #672

yurishkuro opened this issue Mar 20, 2020 · 0 comments · Fixed by #738

Comments

@yurishkuro
Copy link
Member

Similar to #671: Since Jaeger is planning to start using otel collector, I wanted to check what code quality tooling is being used here. I only saw basic lint in the Makefile. Consider adding these:

  • github.com/securego/gosec/cmd/gosec
  • honnef.co/go/tools/cmd/staticcheck
This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
@bogdandrutu bogdandrutu mentioned this issue Mar 28, 2020
Merged
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@evantorrie @MrAlias @jmacd
Remove references in godoc comments to WithKeys (open-telemetry#672)
3809f7b 
* Remove references in godoc comments to WithKeys

WithKeys was removed in PR#639

* Apply suggestions from code review

Fix copy pasta

Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@bjsignalfx
Fix broken links (open-telemetry#672)
4980f1f
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@lalitb
Release for 0.4.0 (open-telemetry#672)
3ce3e76
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@puckpuck
support demo 1.3.1 release (open-telemetry#672)
5250ea6 
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable gosec in CI, takes ~50sec so make it separate job. bogdandrutu/opentelemetry-collector
1 participant
@yurishkuro