Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix G307 errors in gosec evaluation #704

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 26, 2020

Fix this issue:

[/Users/lazy/github/opentelemetry-collector/testbed/tests/scenarios.go:134] - G307 (CWE-): Deferring unsafe method "*os.File" on type "Close" (Confidence: HIGH, Severity: MEDIUM)
  > defer file.Close()

Updates #672

@bogdandrutu bogdandrutu changed the title Fix G07 errors in gosec evaluation Fix G307 errors in gosec evaluation Mar 26, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@pjanotti pjanotti merged commit e8a218e into open-telemetry:master Mar 26, 2020
@bogdandrutu bogdandrutu deleted the gosec branch March 26, 2020 16:39
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
- Change all the components moved from core to contrib
- Remove usage of deprecated traceetranslator.AttributeMapToMap
- Copy https://github.com/open-telemetry/opentelemetry-collector/tree/f6f4b8705024f5481bfbad394aa950fd32da257b/internal/testutil that became an internal package to tests/testutils/
- Copy https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/2d1672ce1a5391eb5ba06ea3f2f01440008de2d8/receiver/jmxreceiver/internal/subprocess package that became internal to tests/testutil/subprocess until open-telemetry/opentelemetry-collector-contrib#5060 is resolved
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants