-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable static-check and add gosec (not enabled) #677
Conversation
c11666c
to
4571d9b
Compare
@@ -82,7 +82,7 @@ func (f *Factory) CustomUnmarshaler() receiver.CustomUnmarshaler { | |||
// these protocols were excluded during normal loading and we need to add defaults for them | |||
vSub := v.Sub(viperKey) | |||
if vSub == nil { | |||
return fmt.Errorf("Jaeger receiver config is empty") | |||
return fmt.Errorf("empty config for Jaeger receiver") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to change this because strict-check does not like error messages that start with upper-case.
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 75.27% 75.30% +0.03%
==========================================
Files 156 156
Lines 11086 11084 -2
==========================================
+ Hits 8345 8347 +2
+ Misses 2335 2332 -3
+ Partials 406 405 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
ebe7908
to
2649126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Please file issues for each security issue found and we will have a look.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@tigrannajaryan will start fixing some easy once then file issues for the remaining. I don't know what is happening with Travis the build is finished but does not update the status. |
Updates #672
Need to understand how badly are the errors for gosec: