Enable gosec in CI, takes ~50sec so make it separate job. #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
bogdandrutu
force-pushed
the
gosecbetter
branch
2 times, most recently
from
5ebb79f
to
7d1d73c
Compare
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 84.58% 84.62% +0.03%
==========================================
Files 162 162
Lines 11657 11653 -4
==========================================
+ Hits 9860 9861 +1
+ Misses 1396 1392 -4
+ Partials 401 400 -1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
gosecbetter
branch
2 times, most recently
from
5710dd5
to
dcf9041
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
gosecbetter
branch
from
dcf9041
to
ae05bc0
Compare
owais
approved these changes
Mar 28, 2020
pjanotti
approved these changes
Mar 28, 2020
yurishkuro
reviewed
Mar 29, 2020
| @@ -58,6 +59,7 @@ func SHA1AttributeHahser(attr *tracepb.AttributeValue) *tracepb.AttributeValue { | |||
|
|
|||
| var hashed string | |||
| if len(val) > 0 { | |||
| // #nosec | |||
There was a problem hiding this comment.
I recommend adding explanations in the comments. In the case of unsafe pointer above it's more obvious, but not here.
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Remove the push controller named Meter map * Checkpoint * Remove Provider impls * Add a test * Expose Provider() getter instead of implementing the interface
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #737
Updates: #736
Updates: https://github.com/open-telemetry/opentelemetry-collector/issues/735
Fixes: #672