-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gosec in CI, takes ~50sec so make it separate job. #738
Conversation
5ebb79f
to
7d1d73c
Compare
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 84.58% 84.62% +0.03%
==========================================
Files 162 162
Lines 11657 11653 -4
==========================================
+ Hits 9860 9861 +1
+ Misses 1396 1392 -4
+ Partials 401 400 -1
Continue to review full report at Codecov.
|
5710dd5
to
dcf9041
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dcf9041
to
ae05bc0
Compare
@@ -58,6 +59,7 @@ func SHA1AttributeHahser(attr *tracepb.AttributeValue) *tracepb.AttributeValue { | |||
|
|||
var hashed string | |||
if len(val) > 0 { | |||
// #nosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding explanations in the comments. In the case of unsafe pointer above it's more obvious, but not here.
* Remove the push controller named Meter map * Checkpoint * Remove Provider impls * Add a test * Expose Provider() getter instead of implementing the interface
Updates: #737
Updates: #736
Updates: https://github.com/open-telemetry/opentelemetry-collector/issues/735
Fixes: #672