-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Try to move helpers to create [*]Factory types in component
directly.
#4681
Comments
From @dmitryax, see comment #4679 (comment)
|
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Followup (forgot to do it) after open-telemetry#4805 Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Followup (forgot to do it) after open-telemetry#4805 Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Followup (forgot to do it) after open-telemetry#4805 Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 20, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 21, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Feb 22, 2022
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Feb 22, 2022
Updates #4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 22, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Feb 22, 2022
Updates #4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 23, 2022
Updates open-telemetry#4681 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Feb 23, 2022
This was referenced Mar 16, 2022
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Mar 23, 2022
Fixes open-telemetry#4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Mar 23, 2022
Fixes open-telemetry#4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Mar 25, 2022
Fixes #4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this issue
Jun 7, 2022
Fixes open-telemetry#4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a draft PR #4679, which shows that it can improve things, also it can definitely help with package dependencies graph (component -> internal, helpers -> {component, internal}), which does not allow us for the moment to split in separate modules the
component
package. This proposal does not suggest to split in separate modules (clarification for people that like to find different interpretation), just lists this impediment for future possibilities.The text was updated successfully, but these errors were encountered: