Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Try to move helpers to create [*]Factory types in component directly. #4681

Closed
bogdandrutu opened this issue Jan 13, 2022 · 1 comment · Fixed by #5069
Closed

[Proposal] Try to move helpers to create [*]Factory types in component directly. #4681

bogdandrutu opened this issue Jan 13, 2022 · 1 comment · Fixed by #5069
Assignees
@bogdandrutu

Comments

@bogdandrutu
Copy link
Member

There is a draft PR #4679, which shows that it can improve things, also it can definitely help with package dependencies graph (component -> internal, helpers -> {component, internal}), which does not allow us for the moment to split in separate modules the component package. This proposal does not suggest to split in separate modules (clarification for people that like to find different interpretation), just lists this impediment for future possibilities.
@bogdandrutu
Copy link
Member Author

From @dmitryax, see comment #4679 (comment)

Wrapping it all in a struct maybe seems not as clean as an interface, but straighten the dependency chain is much valuable I believe. Right now it's very convoluted.

@bogdandrutu bogdandrutu mentioned this issue Jan 20, 2022
Merged
@bogdandrutu bogdandrutu mentioned this issue Feb 3, 2022
Merged
@bogdandrutu bogdandrutu mentioned this issue Feb 19, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
5c851ea 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Feb 20, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
be6881a 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
ab8e97d 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move tests for deprecated extensionhelper to component
6016c6f 
Followup (forgot to do it) after open-telemetry#4805

Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Feb 20, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
1cc6568 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move tests for deprecated extensionhelper to component
b2e937d 
Followup (forgot to do it) after open-telemetry#4805

Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
02c94aa 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
6e994fc 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
5cfdf68 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
b13962e 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move tests for deprecated extensionhelper to component
d40004f 
Followup (forgot to do it) after open-telemetry#4805

Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from receiverhelper to component.
5bdac65 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Feb 20, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 20, 2022
@bogdandrutu
Move everything from processorhelper to component.
7d71d61 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from exporterhelper to component.
e014752 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Feb 21, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from exporterhelper to component.
2bc6cc4 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from processorhelper to component.
4950db6 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from receiverhelper to component.
be7d942 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from exporterhelper to component.
7f7344d 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from processorhelper to component.
4bee2de 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 21, 2022
@bogdandrutu
Move everything from receiverhelper to component.
e2106fc 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Feb 22, 2022
@bogdandrutu
Move tests for deprecated extensionhelper to component (#4890)
8bcb5f0 
Followup (forgot to do it) after #4805

Updates #4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from processorhelper to component.
4c72cfb 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from processorhelper to component.
5852a33 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component.
73f258f 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component.
08e4627 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component.
82beed8 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from receiverhelper to component.
891cb7f 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component.
8f30631 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from processorhelper to component.
0bf4516 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from processorhelper to component.
02a0a3f 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from processorhelper to component. (#4889)
004dd4d 
Updates #4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component.
cf4fe13 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from receiverhelper to component.
1f7c2ad 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from receiverhelper to component.
24fb0c9 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Feb 22, 2022
@bogdandrutu
Move everything from exporterhelper to component. (#4899)
83c6ed1 
Updates #4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 23, 2022
@bogdandrutu
Move everything from exporterhelper to component. (open-telemetry#4899)
c0c06f4 
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Feb 23, 2022
@bogdandrutu
Move everything from exporterhelper to component. (#4899) (#4891)
c9c2531 
Updates #4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu self-assigned this Mar 16, 2022
This was referenced Mar 16, 2022
Merged
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 23, 2022
@bogdandrutu
Deprecate last funcs/structs in componenthelper.
435009f 
Fixes open-telemetry#4681

These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu mentioned this issue Mar 23, 2022
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Mar 23, 2022
@bogdandrutu
Deprecate last funcs/structs in componenthelper
183f72d 
Fixes open-telemetry#4681

These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Mar 25, 2022
@bogdandrutu
Deprecate last funcs/structs in componenthelper (#5069)
6f4057b 
Fixes #4681

These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this issue Jun 7, 2022
@bogdandrutu @Nicholaswang
Deprecate last funcs/structs in componenthelper (open-telemetry#5069)
2222f00 
Fixes open-telemetry#4681

These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate last funcs/structs in componenthelper bogdandrutu/opentelemetry-collector
1 participant
@bogdandrutu