Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directly the consumer helper funcs in the other helpers packages. #4719

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jan 20, 2022

Try to understand if the Component helper is necessary, or only having the helper funcs is enough.

Updates #4681

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Try to understand if the Component helper is necessary, or only having the helper funcs is enough.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and jpkrohling January 20, 2022 23:22
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4719 (1ed1a87) into main (9eb2817) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4719      +/-   ##
==========================================
- Coverage   90.72%   90.72%   -0.01%     
==========================================
  Files         179      179              
  Lines       10690    10688       -2     
==========================================
- Hits         9699     9697       -2     
  Misses        770      770              
  Partials      221      221              
Impacted Files Coverage Δ
component/componenttest/nop_exporter.go 100.00% <ø> (ø)
component/componenttest/nop_extension.go 100.00% <ø> (ø)
component/componenttest/nop_processor.go 100.00% <ø> (ø)
component/componenttest/nop_receiver.go 100.00% <ø> (ø)
exporter/exporterhelper/common.go 94.25% <100.00%> (-0.13%) ⬇️
processor/processorhelper/logs.go 89.65% <100.00%> (+0.36%) ⬆️
processor/processorhelper/metrics.go 89.65% <100.00%> (+0.36%) ⬆️
processor/processorhelper/processor.go 100.00% <100.00%> (ø)
processor/processorhelper/traces.go 89.65% <100.00%> (+0.36%) ⬆️
receiver/scraperhelper/scraper.go 87.50% <100.00%> (-1.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb2817...1ed1a87. Read the comment docs.

@Aneurysm9
Copy link
Member

I think this looks like an improvement. Does it even break anything or is it just removing a layer of indirection?

@bogdandrutu
Copy link
Member Author

Does it even break anything or is it just removing a layer of indirection?

@Aneurysm9 not all my PRs are breaking things :))

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 25, 2022
@bogdandrutu bogdandrutu merged commit 0ef0a9c into open-telemetry:main Jan 26, 2022
@bogdandrutu bogdandrutu deleted the usedirectfuncs branch January 26, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants