Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move everything from processorhelper to component. #4889

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

bogdandrutu
Copy link
Member

Updates #4681

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and Aneurysm9 February 20, 2022 17:35
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #4889 (02a0a3f) into main (27f7607) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4889      +/-   ##
==========================================
- Coverage   90.69%   90.69%   -0.01%     
==========================================
  Files         181      181              
  Lines       10619    10618       -1     
==========================================
- Hits         9631     9630       -1     
  Misses        772      772              
  Partials      216      216              
Impacted Files Coverage Δ
internal/testcomponents/example_processor.go 89.47% <ø> (ø)
component/componenttest/nop_processor.go 100.00% <100.00%> (ø)
component/processor.go 100.00% <100.00%> (ø)
processor/batchprocessor/factory.go 100.00% <100.00%> (ø)
processor/memorylimiterprocessor/factory.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f7607...02a0a3f. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the processorhelper branch 10 times, most recently from 4950db6 to 4bee2de Compare February 21, 2022 01:42
component/factories_test.go Outdated Show resolved Hide resolved
component/processor.go Outdated Show resolved Hide resolved
component/processor.go Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member Author

@dmitryax PTAL.

Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

Based on the fact that multiple approvers already approved similar changes to this for component helpers and extension helpers, I will merge this.

@bogdandrutu bogdandrutu merged commit 004dd4d into open-telemetry:main Feb 22, 2022
@bogdandrutu bogdandrutu deleted the processorhelper branch October 14, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants