Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate consumerhelper, move helpers to consumer #5006

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 16, 2022

Updates #4681

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #5006 (f544380) into main (e214f71) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5006      +/-   ##
==========================================
+ Coverage   90.92%   90.96%   +0.03%     
==========================================
  Files         183      183              
  Lines       10692    10692              
==========================================
+ Hits         9722     9726       +4     
+ Misses        752      749       -3     
+ Partials      218      217       -1     
Impacted Files Coverage Δ
consumer/consumer.go 100.00% <100.00%> (ø)
consumer/logs.go 100.00% <100.00%> (ø)
consumer/metrics.go 100.00% <100.00%> (ø)
consumer/traces.go 100.00% <100.00%> (ø)
exporter/exporterhelper/common.go 94.25% <100.00%> (ø)
exporter/exporterhelper/logs.go 84.74% <100.00%> (ø)
exporter/exporterhelper/metrics.go 84.74% <100.00%> (ø)
exporter/exporterhelper/traces.go 86.88% <100.00%> (ø)
processor/processorhelper/logs.go 89.65% <100.00%> (ø)
processor/processorhelper/metrics.go 89.65% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e214f71...f544380. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit ce71309 into open-telemetry:main Mar 16, 2022
@bogdandrutu bogdandrutu deleted the depconsumerhelper branch March 16, 2022 12:24
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants