feat: add FeaturedHighlightPanel component to design system
#1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdougie
requested changes
Jun 27, 2023
components/molecules/FeaturedHighlightsPanel/featured-highlights-panel.tsx
Outdated
Show resolved
Hide resolved
components/molecules/FeaturedHighlightsPanel/featured-highlights-panel.tsx
Outdated
Show resolved
Hide resolved
NsdHSO
reviewed
Jun 28, 2023
components/molecules/FeaturedHighlightsPanel/featured-highlights-panel.tsx
Outdated
Show resolved
Hide resolved
NsdHSO
reviewed
Jun 28, 2023
components/molecules/FeaturedHighlightsPanel/featured-highlights-panel.tsx
Outdated
Show resolved
Hide resolved
bdougie
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Can you open a corresponding issue for implementation of this?
Featured highlights can be the ones with the most reaction count. We should also enable the ability manual select highlights to be featured as well.
Would love to start seeing these components start making on the page.
Yes, i will... But a question is: are we implementing the logic for the featured highlight in the FE? |
OgDev-01
added
needs-approval
and removed
needs review
brandonroberts
approved these changes
Jun 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
## [1.54.0-beta.9](v1.54.0-beta.8...v1.54.0-beta.9) (2023-06-28) ### 🍕 Features * add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c))
|
🎉 This PR is included in version 1.54.0-beta.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
IMHO, I think we need to keep FE clean, just to be a display for the Backend |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
## [1.54.0](v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f)) * add `BillBoard` component to design system ([#1306](#1306)) ([1181cfd](1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c)) * add `UserCard` component to storybook design system ([#1295](#1295)) ([6867011](6867011)) * add highlight prompt to design system ([#1297](#1297)) ([4a85e74](4a85e74)) * add top users panel component to design system ([#1300](#1300)) ([9c05fec](9c05fec)) * add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](#1283)) ([b7280ab](b7280ab))
|
🎉 This PR is included in version 1.54.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.54.0-beta.9](open-sauced/app@v1.54.0-beta.8...v1.54.0-beta.9) (2023-06-28) ### 🍕 Features * add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.54.0](open-sauced/app@v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f)) * add `BillBoard` component to design system ([#1306](open-sauced/app#1306)) ([1181cfd](open-sauced/app@1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c)) * add `UserCard` component to storybook design system ([#1295](open-sauced/app#1295)) ([6867011](open-sauced/app@6867011)) * add highlight prompt to design system ([#1297](open-sauced/app#1297)) ([4a85e74](open-sauced/app@4a85e74)) * add top users panel component to design system ([#1300](open-sauced/app#1300)) ([9c05fec](open-sauced/app@9c05fec)) * add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](open-sauced/app#1283)) ([b7280ab](open-sauced/app@b7280ab))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add a new component
FeaturedHighlightsPanelto display a list of featured highlights. It takes an array of objects containingidandtitleas props. Each highlight is displayed as a link to the corresponding feed. Also, add a story for the component with sample data.Generated using OpenSauced.
Related Tickets & Documents
Closes #1291
Mobile & Desktop Screenshots/Recordings
hovered
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?