Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix yellow color for <Pill /> component #1299

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

foxyblocks
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Fixes the <Pill /> component so it renders yellow text correctly. It was previously referencing a non-existent text color class which caused it to just take the text color for its parent context.

Mobile & Desktop Screenshots/Recordings

CleanShot 2023-06-26 at 11 31 44@2x

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jun 26, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit f82af9d
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6499e01d57f8d30008176a09
😎 Deploy Preview https://deploy-preview-1299--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 26, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit f82af9d
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6499e01dbc259d0008be255c
😎 Deploy Preview https://deploy-preview-1299--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@foxyblocks foxyblocks marked this pull request as ready for review June 26, 2023 18:59
@foxyblocks foxyblocks requested a review from OgDev-01 June 26, 2023 18:59
@foxyblocks foxyblocks changed the title fix: Fix pill yellow text color fix: Fix yellow color for <Pill /> component Jun 26, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@brandonroberts brandonroberts merged commit 2f2d9f5 into beta Jun 26, 2023
@brandonroberts brandonroberts deleted the fix-pill-color branch June 26, 2023 19:27
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
## [1.54.0-beta.3](v1.54.0-beta.2...v1.54.0-beta.3) (2023-06-26)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.54.0-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
## [1.54.0](v1.53.0...v1.54.0) (2023-06-28)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5))

### πŸ• Features

*  hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f))
* add `BillBoard` component to design system ([#1306](#1306)) ([1181cfd](1181cfd))
* add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c))
* add `UserCard` component to storybook design system ([#1295](#1295)) ([6867011](6867011))
* add highlight prompt to design system ([#1297](#1297)) ([4a85e74](4a85e74))
* add top users panel component to design system ([#1300](#1300)) ([9c05fec](9c05fec))
* add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5))
* allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b))
* implemented/added scroll-area component to design-system  ([#1283](#1283)) ([b7280ab](b7280ab))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.54.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.54.0-beta.3](open-sauced/app@v1.54.0-beta.2...v1.54.0-beta.3) (2023-06-26)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.54.0](open-sauced/app@v1.53.0...v1.54.0) (2023-06-28)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5))

### πŸ• Features

*  hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f))
* add `BillBoard` component to design system ([#1306](open-sauced/app#1306)) ([1181cfd](open-sauced/app@1181cfd))
* add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c))
* add `UserCard` component to storybook design system ([#1295](open-sauced/app#1295)) ([6867011](open-sauced/app@6867011))
* add highlight prompt to design system ([#1297](open-sauced/app#1297)) ([4a85e74](open-sauced/app@4a85e74))
* add top users panel component to design system ([#1300](open-sauced/app#1300)) ([9c05fec](open-sauced/app@9c05fec))
* add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5))
* allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b))
* implemented/added scroll-area component to design-system  ([#1283](open-sauced/app#1283)) ([b7280ab](open-sauced/app@b7280ab))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants