Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add URL for collaboration requests #1305

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Jun 27, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Adds a URL to link to collaboration requests
  • Allows direct link to "Requests" tab for the logged in user to see pending collaboration requests

Example URL:

https://deploy-preview-1305--oss-insights.netlify.app/user/bdougie/requests

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jun 27, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 28e1990
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/649b3daff279760008703ebd
😎 Deploy Preview https://deploy-preview-1305--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 27, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 28e1990
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/649b3dafc38d19000888be99
😎 Deploy Preview https://deploy-preview-1305--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@brandonroberts brandonroberts force-pushed the feat-collaboration-requests-url branch from 15e2c63 to 28e1990 Compare June 27, 2023 19:51
@brandonroberts brandonroberts requested a review from OgDev-01 June 27, 2023 20:20
Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are we creating ui for this in the future?

@brandonroberts
Copy link
Contributor Author

We already have UI for this. This allows linking to the Requests tab in the contributor profile for the logged in user to see pending requests

@OgDev-01
Copy link
Contributor

With this feature, We should keep the requests tab for users who have at least one request in their inbox.

image

will open an issue for these minor adjustments

@brandonroberts brandonroberts merged commit b3f8ea5 into beta Jun 28, 2023
@brandonroberts brandonroberts deleted the feat-collaboration-requests-url branch June 28, 2023 16:15
github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
## [1.54.0-beta.8](v1.54.0-beta.7...v1.54.0-beta.8) (2023-06-28)

### πŸ• Features

* add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.54.0-beta.8 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
## [1.54.0](v1.53.0...v1.54.0) (2023-06-28)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5))

### πŸ• Features

*  hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f))
* add `BillBoard` component to design system ([#1306](#1306)) ([1181cfd](1181cfd))
* add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c))
* add `UserCard` component to storybook design system ([#1295](#1295)) ([6867011](6867011))
* add highlight prompt to design system ([#1297](#1297)) ([4a85e74](4a85e74))
* add top users panel component to design system ([#1300](#1300)) ([9c05fec](9c05fec))
* add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5))
* allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b))
* implemented/added scroll-area component to design-system  ([#1283](#1283)) ([b7280ab](b7280ab))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.54.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.54.0-beta.8](open-sauced/app@v1.54.0-beta.7...v1.54.0-beta.8) (2023-06-28)

### πŸ• Features

* add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.54.0](open-sauced/app@v1.53.0...v1.54.0) (2023-06-28)

### πŸ› Bug Fixes

* fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5))

### πŸ• Features

*  hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f))
* add `BillBoard` component to design system ([#1306](open-sauced/app#1306)) ([1181cfd](open-sauced/app@1181cfd))
* add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c))
* add `UserCard` component to storybook design system ([#1295](open-sauced/app#1295)) ([6867011](open-sauced/app@6867011))
* add highlight prompt to design system ([#1297](open-sauced/app#1297)) ([4a85e74](open-sauced/app@4a85e74))
* add top users panel component to design system ([#1300](open-sauced/app#1300)) ([9c05fec](open-sauced/app@9c05fec))
* add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5))
* allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b))
* implemented/added scroll-area component to design-system  ([#1283](open-sauced/app#1283)) ([b7280ab](open-sauced/app@b7280ab))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants