feat: hide highlights tab components on profiles without highlights #1304

babblebey · 2023-06-27T17:54:15Z

What type of PR is this? (check all applicable)

Description

This PR implements the ability to Hide Highlight Tabs Content and Trigger components for user Profiles that either haven't connected their GitHub or most notably haven't posted any highlights.

This was done by conditionally rendering the hidden utility class on the TabsTrigger component item.

<TabsTrigger
  key={tab}
  className={clsx(
    ...
    user?.user_metadata.user_name !== login && !hasHighlights && tab === "Highlights" && "hidden",
    ...
  )}
  value={tab}
>
  ...
</TabsTrigger>

...and conditionally rendering its associated TabsContent component

{(user?.user_metadata.user_name === login || hasHighlights) && (
  <TabsContent>
    ...
  </TabsContent>
)}

I also address the case where currently logged in user has no highlights, ensuring the Highlight Tab Components are rendered/displayed in the case where they are on their own profile. Screenshots of different cases below.

Related Tickets & Documents

fixes #1227

Mobile & Desktop Screenshots/Recordings

Profile with Highlights

Profile without Highlights

Currently Logged In User Profile without Highlights

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

None

[optional] What gif best describes this PR or how it makes you feel?

…gger' component

netlify · 2023-06-27T17:54:20Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`b1cf2c2`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/649b22493771260008e87bbc
😎 Deploy Preview	https://deploy-preview-1304--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-06-27T17:54:21Z

✅ Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`b1cf2c2`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/649b22498d11e40008245253
😎 Deploy Preview	https://deploy-preview-1304--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions

PR Compliance Checks Passed!

brandonroberts · 2023-06-27T19:39:08Z

@babblebey works correctly in my testing also

OgDev-01

🍕

## [1.54.0-beta.6](v1.54.0-beta.5...v1.54.0-beta.6) (2023-06-27) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f))

github-actions · 2023-06-27T20:43:30Z

🎉 This PR is included in version 1.54.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.54.0](v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f)) * add `BillBoard` component to design system ([#1306](#1306)) ([1181cfd](1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c)) * add `UserCard` component to storybook design system ([#1295](#1295)) ([6867011](6867011)) * add highlight prompt to design system ([#1297](#1297)) ([4a85e74](4a85e74)) * add top users panel component to design system ([#1300](#1300)) ([9c05fec](9c05fec)) * add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](#1283)) ([b7280ab](b7280ab))

github-actions · 2023-06-28T17:56:24Z

🎉 This PR is included in version 1.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.54.0-beta.6](open-sauced/app@v1.54.0-beta.5...v1.54.0-beta.6) (2023-06-27) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f))

## [1.54.0](open-sauced/app@v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f)) * add `BillBoard` component to design system ([#1306](open-sauced/app#1306)) ([1181cfd](open-sauced/app@1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c)) * add `UserCard` component to storybook design system ([#1295](open-sauced/app#1295)) ([6867011](open-sauced/app@6867011)) * add highlight prompt to design system ([#1297](open-sauced/app#1297)) ([4a85e74](open-sauced/app@4a85e74)) * add top users panel component to design system ([#1300](open-sauced/app#1300)) ([9c05fec](open-sauced/app@9c05fec)) * add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](open-sauced/app#1283)) ([b7280ab](open-sauced/app@b7280ab))

babblebey added 2 commits June 27, 2023 18:17

feat: conditionally render/display Highlights Tabs 'Content' and 'Tri…

08af6e1

…gger' component

refactor!: cleaned un-used conditional logic

b1cf2c2

github-actions bot reviewed Jun 27, 2023

View reviewed changes

babblebey changed the title ~~Feat: hide highlights tab components on profiles without highlights~~ feat: hide highlights tab components on profiles without highlights Jun 27, 2023

brandonroberts approved these changes Jun 27, 2023

View reviewed changes

brandonroberts requested a review from OgDev-01 June 27, 2023 19:39

OgDev-01 approved these changes Jun 27, 2023

View reviewed changes

OgDev-01 added the ready-to-merge label Jun 27, 2023

brandonroberts merged commit 976739f into open-sauced:beta Jun 27, 2023

github-actions bot added the released on @beta label Jun 27, 2023

github-actions bot added the released label Jun 28, 2023

babblebey deleted the feat--hide-highlights-tab-components-on-profiles-without-highlights branch July 31, 2023 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: hide highlights tab components on profiles without highlights #1304

feat: hide highlights tab components on profiles without highlights #1304

babblebey commented Jun 27, 2023 •

edited

Loading

netlify bot commented Jun 27, 2023 •

edited

Loading

netlify bot commented Jun 27, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

brandonroberts commented Jun 27, 2023

OgDev-01 left a comment

github-actions bot commented Jun 27, 2023

github-actions bot commented Jun 28, 2023

feat: hide highlights tab components on profiles without highlights #1304

feat: hide highlights tab components on profiles without highlights #1304

Conversation

babblebey commented Jun 27, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Jun 27, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Jun 27, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

brandonroberts commented Jun 27, 2023

OgDev-01 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2023

github-actions bot commented Jun 28, 2023

babblebey commented Jun 27, 2023 •

edited

Loading

netlify bot commented Jun 27, 2023 •

edited

Loading

netlify bot commented Jun 27, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading