REL: 3.2.2 #1078
Merged
REL: 3.2.2 #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document says: ``` ... ``` but later the headings become imperatives: ``` ``` Imperatives changed to adjectives. Backport of gh-996
…nibabel/testing/__init__.py import pkg_resources Backport of gh-1009
Illegal class 'int' raised; will result in a TypeError being raised instead. Backport of gh-1048
FIX: LGTM error: Special method has incorrect signature Too few parameters for special method __getitem__, which has 1 parameter, but should have 2, in class FileBasedImage. https://lgtm.com/rules/7850093/ FIX: LGTM warning: Unnecessary 'else' clause in loop This 'for' statement has a redundant 'else' as no 'break' is present in the body. https://lgtm.com/rules/5980098/ FIX: LGTM warning: Variable defined multiple times This assignment to 'patient_info' is unnecessary as it is redefined here before this value is used. https://lgtm.com/rules/1800095/ FIX: LGTM recommendations: Unused import Import of '...' is not used. https://lgtm.com/rules/6770079/ Backport of gh-1043
Codecov Report
@@ Coverage Diff @@
## maint/3.2.x #1078 +/- ##
===============================================
+ Coverage 91.84% 91.87% +0.03%
===============================================
Files 101 101
Lines 12551 12551
Branches 2209 2406 +197
===============================================
+ Hits 11527 11531 +4
+ Misses 685 683 -2
+ Partials 339 337 -2
Continue to review full report at Codecov.
|
fix cifti2 transform loading without newlines add test for space separated affine Backport of gh-1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a number of deprecations due in 4.0, and the need for some concerted attention to doing things right, I've been slow to get that release out. So before working on that, I'm putting out a bug-fix release that includes backports of several fixes and cleanups that have accrued in master since our last release ~16 months ago.
I don't have high hopes for passing CI, but I do want to review what's failing before merging and releasing.
Please review your Zenodo entries, @HippocampusGirl, @DimitriPapadopoulos, @hrnciar, @anibalsolon, @vanandrew.
Pre-release checklist
doc/source/index.rstand add any authors not yet acknowledged..mailmap fileif there are any duplicate authors listed fromgit shortlog -nse.LONG_DESCRIPTIONininfo.pyby runningmake refresh-readme.setup.cfg(e.g.,install_requires,options.extras_require) and indoc/source/installation.rstand inrequirements.txtand.travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.pytest --doctest-modules nibabelAdapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist