Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Unclosed file warning in GiftiImage #1038

Merged
merged 2 commits into from
Aug 9, 2021
Merged

FIX: Unclosed file warning in GiftiImage #1038

merged 2 commits into from
Aug 9, 2021

Conversation

HippocampusGirl
Copy link
Contributor

@effigies effigies changed the title FIX unclosed file warning in GiftiImage FIX: Unclosed file warning in GiftiImage Aug 9, 2021
effigies
effigies approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@codecov
Copy link

codecov bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #1038 (e80fff4) into master (ea68c4e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         100      100           
  Lines       12205    12205           
  Branches     2136     2136           
=======================================
  Hits        11261    11261           
  Misses        616      616           
  Partials      328      328
Impacted Files Coverage Δ
nibabel/gifti/gifti.py 95.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea68c4e...e80fff4. Read the comment docs.

@effigies
Copy link
Member

effigies commented Aug 9, 2021

Failures are unrelated. Opened an issue on numpy to work toward resolving them.

@effigies effigies merged commit c162e65 into nipy:master Aug 9, 2021
@HippocampusGirl HippocampusGirl deleted the fix/gifti-unclosed-file-warning branch August 9, 2021 18:34
@HippocampusGirl
Copy link
Contributor Author

Awesome

effigies pushed a commit that referenced this pull request Feb 7, 2022
@HippocampusGirl @effigies
Fix #1035 unclosed file warning in GiftiImage
f436b73 
- Change as proposed by @effigies

Test for `ResourceWarning` in `GiftiImage`

Backport of gh-1038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed file warning in GiftiImage.to_file_map
2 participants
@HippocampusGirl @effigies