Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 4.0.0rc0 #1081

Merged
merged 2 commits into from
Jun 6, 2022
Merged

REL: 4.0.0rc0 #1081

merged 2 commits into from
Jun 6, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 7, 2022

Preparation for 4.0.0rc0. As noted in #1078, the prospect of many deprecations needing to be double-checked has slowed down my ability to make this release happen. It still needs to happen, and it should start with a release candidate.

We've jumped a few numpy versions and dropped Python 3.6, and we have some improvements that will make things easier for downstream projects.

I think let's aim for next Monday to give everyone time to polish off enhancement/new feature PRs. Additional bug fixes can come post-release.

Pre-release checklist

  • Review the open list of nibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
  • Review and update the release notes. Review and update the Changelog file.
  • Look at doc/source/index.rst and add any authors not yet acknowledged.
  • Use the opportunity to update the .mailmap file if there are any duplicate authors listed from git shortlog -nse.
  • Check the copyright year in doc/source/conf.py
  • Refresh the README.rst text from the LONG_DESCRIPTION in info.py by running make refresh-readme.
  • Check the dependencies listed in setup.cfg (e.g., install_requires, options.extras_require) and in doc/source/installation.rst and in requirements.txt and .travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
  • Make sure all tests pass (from the nibabel root directory): pytest --doctest-modules nibabel

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1081 (1312493) into master (1312493) will not change coverage.
The diff coverage is n/a.

❗ Current head 1312493 differs from pull request most recent head 1741077. Consider uploading reports for the commit 1741077 to get more accurate results

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         100      100           
  Lines       12342    12342           
  Branches     2419     2419           
=======================================
  Hits        11392    11392           
  Misses        625      625           
  Partials      325      325           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1312493...1741077. Read the comment docs.

@effigies effigies force-pushed the rel/4.0.0rc0 branch 3 times, most recently from 82449bf to 729f3e3 Compare March 7, 2022 15:30
@effigies
Copy link
Member Author

effigies commented Jun 3, 2022

I think let's aim for next Monday to give everyone time to polish off enhancement/new feature PRs.

Well that sure didn't happen. But the plan is now to aim for this coming Monday, June 6.

@effigies effigies merged commit f8de8ce into master Jun 6, 2022
@effigies effigies deleted the rel/4.0.0rc0 branch January 3, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant