FIX: LGTM alerts #1043
Merged
FIX: LGTM alerts #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1043 +/- ##
=======================================
Coverage 92.26% 92.27%
=======================================
Files 100 100
Lines 12205 12204 -1
Branches 2136 2136
=======================================
Hits 11261 11261
+ Misses 616 615 -1
Partials 328 328
Continue to review full report at Codecov.
|
Too few parameters for special method __getitem__, which has 1 parameter, but should have 2, in class FileBasedImage. https://lgtm.com/rules/7850093/
This 'for' statement has a redundant 'else' as no 'break' is present in the body. https://lgtm.com/rules/5980098/
This assignment to 'patient_info' is unnecessary as it is redefined here before this value is used. https://lgtm.com/rules/1800095/
Import of '...' is not used. https://lgtm.com/rules/6770079/
DimitriPapadopoulos
force-pushed
the
lgtm
branch
from
e677a67 to
cb72438
Compare
effigies
pushed a commit
that referenced
this pull request
Feb 7, 2022
FIX: LGTM error: Special method has incorrect signature Too few parameters for special method __getitem__, which has 1 parameter, but should have 2, in class FileBasedImage. https://lgtm.com/rules/7850093/ FIX: LGTM warning: Unnecessary 'else' clause in loop This 'for' statement has a redundant 'else' as no 'break' is present in the body. https://lgtm.com/rules/5980098/ FIX: LGTM warning: Variable defined multiple times This assignment to 'patient_info' is unnecessary as it is redefined here before this value is used. https://lgtm.com/rules/1800095/ FIX: LGTM recommendations: Unused import Import of '...' is not used. https://lgtm.com/rules/6770079/ Backport of gh-1043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some alerts where the solution is obvious.
Other alerts can be found here:
https://lgtm.com/projects/g/nipy/nibabel/