Allow edit on link share on a file #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
editOnShareLink
branch
from
b7e554c
to
8805d9a
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
editOnShareLink
branch
from
8805d9a
to
81ed32f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3923 +/- ##
===========================================
- Coverage 6.59% 6.59% -0.01%
Complexity 1 1
===========================================
Files 320 320
Lines 30806 30809 +3
Branches 4393 4393
===========================================
- Hits 2033 2031 -2
- Misses 28474 28482 +8
+ Partials 299 296 -3
|
Codecov Report
@@ Coverage Diff @@
## master #3923 +/- ##
===========================================
- Coverage 6.59% 6.58% -0.02%
Complexity 1 1
===========================================
Files 320 320
Lines 30806 30809 +3
Branches 4393 4393
===========================================
- Hits 2033 2029 -4
- Misses 28474 28483 +9
+ Partials 299 297 -2
|
Codacy276Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Apr 29, 2019
nextcloud-android-bot
pushed a commit
that referenced
this pull request
May 2, 2019
71f3370 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 0f50088 Merge pull request #3916 from jmue/cleanup/string_compare 7bb07a0 Update wording for store text (#3903) 4c72f3f Merge pull request #3923 from nextcloud/editOnShareLink 81ed32f allow edit on link share on a file 7d01ff7 - fix IT tests - re-organized build.gradle a bit a9afff7 Merge pull request #3929 from nextcloud/dependabot/gradle/org.powermock-powermock-core-2.0.2 71c6d99 bump all other powermock parts to 2.0.2 0421d26 Bump powermock-core from 2.0.0 to 2.0.2 1d28d1b Update with new wording from frontpage de3d3de Merge pull request #3924 from nextcloud/warnOnStable 69dd243 warn for wrong library branch on stable 2379b49 Merge pull request #3921 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.4.0 c2730e8 Bump gradle from 3.3.2 to 3.4.0 b69169f unify empty string compare 8bb654b fix test & review comments d8b9d10 unify empty string compare 2f23a30 remove unused variable (#3920) 92df32e Merge pull request #3918 from nextcloud/codacyCleanup 091c003 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 15ec487 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] da3c497 Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc' b22f517 Merge pull request #3915 from jmue/cleanup/ocfile c7c6a98 use constant e6604c8 use constant caa2a91 Merge pull request #3912 from nextcloud/libraryUsage 334155e some cleanups 28f80cd Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start 2afb934 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 8be1157 Merge pull request #3899 from jmue/cleanup/uriutils 52020a9 direct usage of library project 4062d40 Merge pull request #3908 from nextcloud/missingInjectable 2a08cb4 Initialize global context before MainApp.onCreate() f02f482 Missing Injectable lead to half-stored account 02cbafe Merge pull request #3765 from nextcloud/showSharees dc7a2c0 show sharees 03e04e5 Merge pull request #3889 from nextcloud/checkUserId d65e94b Update wording for store text 585a3d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 533debf - removed useNextcloudUserAgent -> we now use this everytime - removed any oAuth and saml stuff, as we rely on weblogin flow d544fa5 Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager 5b4ffba Merge pull request #3900 from nextcloud/codacyOnMaster 2757244 remove unused code 428a8bb show codacy count only on master 6b44074 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] c62e89b Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8' 442394f Migrate current account getter from AccountUtils to UserAccountManager 182b65e daily dev 20190414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3922
Signed-off-by: tobiasKaminsky tobias@kaminsky.me