Initialize global context before MainApp.onCreate()

[ezaquarii]

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

[ezaquarii]

This could fix #3901 and possibly some other issues.

[mario]

Can I ask why not a module and then provideContext which can be injected everywhere to get application-wide context?

[ezaquarii]

getApplicationContext() is null, as the app context is set somewhere between Application.attachBaseContext() and Application.onCreate(). However, because there is only 1 instance of MainApp, there is no leak, so no worries.

Once the base context is attached, the context is basically functional, with some obscure exceptions around Looper and whatnot. Those should be fully initialized before ContentProvider.onCreate() kicks in.

[ezaquarii]

Can I ask why not a module and then provideContext which can be injected everywhere to get application-wide context?

It is already done.

android/src/main/java/com/nextcloud/client/di/AppModule.java

Line 55 in d544fa5

Context context(Application application) {

However, large portions of the code still call to MainApp.getAppContext() either directly or indirectly via other helpers and it will be a long march to fix this.

The best we can do in this situation is to provide them a valid reference. This can't be worse than NPE. :)

[codecov]

Codecov Report

Merging #3907 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #3907      +/-   ##
===========================================
- Coverage      6.57%   6.51%   -0.06%     
  Complexity        1       1              
===========================================
  Files           320     320              
  Lines         30814   30816       +2     
  Branches       4403    4403              
===========================================
- Hits           2027    2009      -18     
- Misses        28492   28511      +19     
- Partials        295     296       +1

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/owncloud/android/MainApp.java	45.7% <100%> (+0.02%)	0 <0> (ø)	⬇️
...services/firebase/NCFirebaseInstanceIDService.java	0% <0%> (-87.5%)	0% <0%> (ø)
.../services/firebase/NCFirebaseMessagingService.java	0% <0%> (-7.15%)	0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java	29.86% <0%> (-4.17%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	57.99% <0%> (-1.37%)	0% <0%> (ø)
...cloud/android/datamodel/ArbitraryDataProvider.java	11.53% <0%> (-1.29%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (-1.2%)	0% <0%> (ø)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@02cbafe). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #3907   +/-   ##
========================================
  Coverage          ?   6.58%           
  Complexity        ?       1           
========================================
  Files             ?     320           
  Lines             ?   30878           
  Branches          ?    4411           
========================================
  Hits              ?    2032           
  Misses            ?   28550           
  Partials          ?     296

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/com/owncloud/android/MainApp.java	46.04% <100%> (ø)	0 <0> (?)

[nextcloud-android-bot]

Codacy

300

Lint

Type	master	PR
Warnings	57	57
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	80
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	47
Dodgy code Warnings	132
Total	436

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	80
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	47
Dodgy code Warnings	132
Total	436