Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup authentication #3889

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Cleanup authentication #3889

merged 2 commits into from
Apr 15, 2019

Conversation

tobiasKaminsky
Copy link
Member

  • removed useNextcloudUserAgent -> we now use this everytime
  • removed any oAuth and saml stuff, as we rely on weblogin flow

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #3889 into master will increase coverage by 0.04%.
The diff coverage is 5.88%.

@@             Coverage Diff             @@
##             master   #3889      +/-   ##
===========================================
+ Coverage      6.41%   6.45%   +0.04%     
  Complexity        1       1              
===========================================
  Files           323     319       -4     
  Lines         31220   30745     -475     
  Branches       4477    4399      -78     
===========================================
- Hits           2003    1985      -18     
+ Misses        28921   28466     -455     
+ Partials        296     294       -2
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/dialog/SslUntrustedCertDialog.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/com/owncloud/android/MainApp.java 44.71% <ø> (-0.27%) 0 <0> (ø)
...com/owncloud/android/ui/activity/FileActivity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...m/owncloud/android/services/OperationsService.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...operations/RemoveRemoteEncryptedFileOperation.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/com/owncloud/android/utils/EncryptionUtils.java 75.89% <0%> (ø) 0 <0> (ø) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...d/android/authentication/AccountAuthenticator.java 17.14% <0%> (+0.47%) 0 <0> (ø) ⬇️
...loud/android/operations/DownloadFileOperation.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../android/authentication/AuthenticatorActivity.java 1.87% <0%> (+0.3%) 0 <0> (ø) ⬇️
... and 12 more

@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d544fa5). Click here to learn what that means.
The diff coverage is 6.15%.

@@           Coverage Diff            @@
##             master   #3889   +/-   ##
========================================
  Coverage          ?   6.57%           
  Complexity        ?       1           
========================================
  Files             ?     320           
  Lines             ?   30814           
  Branches          ?    4403           
========================================
  Hits              ?    2026           
  Misses            ?   28492           
  Partials          ?     296
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/dialog/SslUntrustedCertDialog.java 0% <ø> (ø) 0 <0> (?)
src/main/java/com/owncloud/android/MainApp.java 45.67% <ø> (ø) 0 <0> (?)
...com/owncloud/android/ui/activity/FileActivity.java 0% <ø> (ø) 0 <0> (?)
...m/owncloud/android/services/OperationsService.java 0% <ø> (ø) 0 <0> (?)
...xtcloud/client/account/UserAccountManagerImpl.java 11.66% <ø> (ø) 0 <0> (?)
...operations/RemoveRemoteEncryptedFileOperation.java 0% <0%> (ø) 0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java 0% <0%> (ø) 0 <0> (?)
...d/android/authentication/AccountAuthenticator.java 17.14% <0%> (ø) 0 <0> (?)
...loud/android/operations/DownloadFileOperation.java 0% <0%> (ø) 0 <0> (?)
.../android/authentication/AuthenticatorActivity.java 1.87% <0%> (ø) 0 <0> (?)
... and 8 more

@nextcloud nextcloud deleted a comment Apr 15, 2019
@nextcloud nextcloud deleted a comment Apr 15, 2019
@nextcloud nextcloud deleted a comment Apr 15, 2019
@nextcloud nextcloud deleted a comment Apr 15, 2019
AndyScherzinger
AndyScherzinger approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the housekeeping efforts

@nextcloud nextcloud deleted a comment Apr 15, 2019
@nextcloud nextcloud deleted a comment Apr 15, 2019
@tobiasKaminsky
- removed useNextcloudUserAgent -> we now use this everytime
533debf 
- removed any oAuth and saml stuff, as we rely on weblogin flow

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Drone: update FindBugs results to reflect reduced error/warning count…
585a3d0 
… [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
@nextcloud nextcloud deleted a comment Apr 15, 2019
@nextcloud nextcloud deleted a comment Apr 15, 2019
@AndyScherzinger
Copy link
Member

Fine with me, will kill any use in combination with a owncloud backend but I am fine with this since we never officially supported it anyways.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

303

Lint

TypemasterPR
Warnings5757
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings80
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings124
Security Warnings47
Dodgy code Warnings132
Total436

@nextcloud-android-bot
Copy link
Collaborator

Codacy

303

Lint

TypemasterPR
Warnings5757
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings80
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings124
Security Warnings47
Dodgy code Warnings132
Total436

@AndyScherzinger AndyScherzinger merged commit 03e04e5 into master Apr 15, 2019
@AndyScherzinger AndyScherzinger deleted the checkUserId branch April 15, 2019 21:00
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.7.0 milestone Apr 15, 2019
@AndyScherzinger AndyScherzinger mentioned this pull request Apr 16, 2019
Closed
nextcloud-android-bot pushed a commit that referenced this pull request May 2, 2019
@tobiasKaminsky
daily dev 20190502
3c51355 
71f3370 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
0f50088 Merge pull request #3916 from jmue/cleanup/string_compare
7bb07a0 Update wording for store text (#3903)
4c72f3f Merge pull request #3923 from nextcloud/editOnShareLink
81ed32f allow edit on link share on a file
7d01ff7 - fix IT tests - re-organized build.gradle a bit
a9afff7 Merge pull request #3929 from nextcloud/dependabot/gradle/org.powermock-powermock-core-2.0.2
71c6d99 bump all other powermock parts to 2.0.2
0421d26 Bump powermock-core from 2.0.0 to 2.0.2
1d28d1b Update with new wording from frontpage
de3d3de Merge pull request #3924 from nextcloud/warnOnStable
69dd243 warn for wrong library branch on stable
2379b49 Merge pull request #3921 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.4.0
c2730e8 Bump gradle from 3.3.2 to 3.4.0
b69169f unify empty string compare
8bb654b fix test & review comments
d8b9d10 unify empty string compare
2f23a30 remove unused variable (#3920)
92df32e Merge pull request #3918 from nextcloud/codacyCleanup
091c003 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
15ec487 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
da3c497 Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc'
b22f517 Merge pull request #3915 from jmue/cleanup/ocfile
c7c6a98 use constant
e6604c8 use constant
caa2a91 Merge pull request #3912 from nextcloud/libraryUsage
334155e some cleanups
28f80cd Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start
2afb934 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
8be1157 Merge pull request #3899 from jmue/cleanup/uriutils
52020a9 direct usage of library project
4062d40 Merge pull request #3908 from nextcloud/missingInjectable
2a08cb4 Initialize global context before MainApp.onCreate()
f02f482 Missing Injectable lead to half-stored account
02cbafe Merge pull request #3765 from nextcloud/showSharees
dc7a2c0 show sharees
03e04e5 Merge pull request #3889 from nextcloud/checkUserId
d65e94b Update wording for store text
585a3d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
533debf - removed useNextcloudUserAgent -> we now use this everytime - removed any oAuth and saml stuff, as we rely on weblogin flow
d544fa5 Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager
5b4ffba Merge pull request #3900 from nextcloud/codacyOnMaster
2757244 remove unused code
428a8bb show codacy count only on master
6b44074 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
c62e89b Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8'
442394f Migrate current account getter from AccountUtils to UserAccountManager
182b65e daily dev 20190414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AndyScherzinger @nextcloud-android-bot