Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup unused code #3899

Merged
merged 1 commit into from
Apr 17, 2019
Merged

cleanup unused code #3899

merged 1 commit into from
Apr 17, 2019

Conversation

jmue
Copy link
Contributor

@jmue jmue commented Apr 15, 2019

remove some unused code (maybee leftover of new androidx.core.content.FileProvider)

Signed-off-by: Jens Mueller <tschenser@gmx.de>
@nextcloud-android-bot
Copy link
Collaborator

Codacy

300

Lint

TypemasterPR
Warnings5757
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings80
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings123
Security Warnings47
Dodgy code Warnings132
Total435

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings80
Internationalization Warnings15
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings124
Security Warnings47
Dodgy code Warnings132
Total436

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3899 into master will increase coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3899      +/-   ##
===========================================
+ Coverage      6.45%   6.57%   +0.12%     
  Complexity        1       1              
===========================================
  Files           325     320       -5     
  Lines         31247   30821     -426     
  Branches       4479    4397      -82     
===========================================
+ Hits           2018    2028      +10     
+ Misses        28931   28495     -436     
  Partials        298     298
Impacted Files Coverage Δ Complexity Δ
...main/java/com/owncloud/android/utils/UriUtils.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/com/nextcloud/client/di/AppModule.java 58.33% <0%> (-41.67%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 79.76% <0%> (-2.39%) 0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java 34.02% <0%> (-0.73%) 0% <0%> (ø)
...va/com/owncloud/android/utils/FilesSyncHelper.java 26.78% <0%> (-0.65%) 0% <0%> (ø)
...wncloud/android/providers/FileContentProvider.java 18.68% <0%> (-0.22%) 0% <0%> (ø)
src/main/java/com/owncloud/android/MainApp.java 45.67% <0%> (-0.06%) 0% <0%> (ø)
...a/com/owncloud/android/utils/FileStorageUtils.java 7.96% <0%> (-0.04%) 0% <0%> (ø)
...com/owncloud/android/ui/activity/BaseActivity.java 1.35% <0%> (-0.02%) 0% <0%> (ø)
...m/owncloud/android/ui/adapter/TemplateAdapter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 64 more

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this finding!

@tobiasKaminsky tobiasKaminsky merged commit 8be1157 into nextcloud:master Apr 17, 2019
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.7.0 milestone Apr 17, 2019
@jmue jmue deleted the cleanup/uriutils branch April 18, 2019 06:47
nextcloud-android-bot pushed a commit that referenced this pull request May 2, 2019
71f3370 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
0f50088 Merge pull request #3916 from jmue/cleanup/string_compare
7bb07a0 Update wording for store text (#3903)
4c72f3f Merge pull request #3923 from nextcloud/editOnShareLink
81ed32f allow edit on link share on a file
7d01ff7 - fix IT tests - re-organized build.gradle a bit
a9afff7 Merge pull request #3929 from nextcloud/dependabot/gradle/org.powermock-powermock-core-2.0.2
71c6d99 bump all other powermock parts to 2.0.2
0421d26 Bump powermock-core from 2.0.0 to 2.0.2
1d28d1b Update with new wording from frontpage
de3d3de Merge pull request #3924 from nextcloud/warnOnStable
69dd243 warn for wrong library branch on stable
2379b49 Merge pull request #3921 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.4.0
c2730e8 Bump gradle from 3.3.2 to 3.4.0
b69169f unify empty string compare
8bb654b fix test & review comments
d8b9d10 unify empty string compare
2f23a30 remove unused variable (#3920)
92df32e Merge pull request #3918 from nextcloud/codacyCleanup
091c003 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
15ec487 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
da3c497 Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc'
b22f517 Merge pull request #3915 from jmue/cleanup/ocfile
c7c6a98 use constant
e6604c8 use constant
caa2a91 Merge pull request #3912 from nextcloud/libraryUsage
334155e some cleanups
28f80cd Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start
2afb934 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
8be1157 Merge pull request #3899 from jmue/cleanup/uriutils
52020a9 direct usage of library project
4062d40 Merge pull request #3908 from nextcloud/missingInjectable
2a08cb4 Initialize global context before MainApp.onCreate()
f02f482 Missing Injectable lead to half-stored account
02cbafe Merge pull request #3765 from nextcloud/showSharees
dc7a2c0 show sharees
03e04e5 Merge pull request #3889 from nextcloud/checkUserId
d65e94b Update wording for store text
585a3d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
533debf - removed useNextcloudUserAgent -> we now use this everytime - removed any oAuth and saml stuff, as we rely on weblogin flow
d544fa5 Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager
5b4ffba Merge pull request #3900 from nextcloud/codacyOnMaster
2757244 remove unused code
428a8bb show codacy count only on master
6b44074 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
c62e89b Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8'
442394f Migrate current account getter from AccountUtils to UserAccountManager
182b65e daily dev 20190414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants