test: Migrated test/unit/util to use node:test
#2546
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 289 289
Lines 45416 45448 +32
=======================================
+ Hits 44140 44172 +32
Misses 1276 1276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| await Promise.all( | ||
| features.map(async ({ feature, method }) => { |
There was a problem hiding this comment.
This one, however, does have the hooks present. Are we sure they are getting applied correctly?
There was a problem hiding this comment.
it is working.
node test/unit/util/application-logging.test.js | grep 'before test' | wc -l
outputs
8
6 for the fixtures and 2 for the standalone
| t.ok(test.obfuscated.includes(obfuscated)) | ||
| } | ||
| function runTest(t, testCase, dialect) { | ||
| t.diagnostic(dialect) |
There was a problem hiding this comment.
Unfortunately, this isn't going to print inline with the actual test in the output. Diagnostic messages get collected and reported after all tests are done 😢
There was a problem hiding this comment.
they seem to post inline
ℹ postgres
ℹ cassandra
✔ uuid_with_braces (0.01925ms)
ℹ postgres
✔ uuid_no_dashes (0.01825ms)
ℹ postgres
✔ uuid_random_dashes (0.017791ms)
ℹ postgres
✔ booleans (0.019708ms)
ℹ mysql
ℹ postgres
ℹ cassandra
ℹ sqlite
✔ in_clause_digits (0.021291ms)
ℹ mysql
ℹ postgres
ℹ oracle
ℹ cassandra
ℹ mssql
✔ in_clause_strings (0.028792ms)
ℹ mysql
ℹ postgres
ℹ oracle
ℹ cassandra
ℹ mssql
✔ should handle line endings (0.045709ms)
bizob2828
force-pushed
the
convert-util
branch
from
486b454
to
d5c230f
Compare
Related Issues
Closes #2539