Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Updated mongodb instrumentation to drop support for versions 2 and 3 #2398

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

bizob2828
Copy link
Member

Description

By droppping 2 and 3, it allowed a lot of clean up. Removed a container running mongo server 3 and only use v 5. Also removed a lot of instrumentation that was being used to parse queries for v2 and 3.

How to Test

npm run versioned:internal mongodb

Related Issues

Closes #2395

jsumners-nr
jsumners-nr previously approved these changes Jul 23, 2024
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplification FTW!

@mrickard mrickard self-assigned this Jul 23, 2024
mrickard
mrickard previously approved these changes Jul 23, 2024
@mrickard mrickard self-requested a review July 23, 2024 17:23
@bizob2828
Copy link
Member Author

i have to fix the esm tests. i'm going to pare these down as they feel like overkill

@bizob2828 bizob2828 dismissed stale reviews from mrickard and jsumners-nr via da71afe July 23, 2024 21:10
@bizob2828 bizob2828 merged commit a0ae32a into newrelic:next Jul 24, 2024
23 checks passed
@bizob2828 bizob2828 deleted the update-mongo-version branch July 24, 2024 13:56
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants