feat!: Dropped support for Node.js 16 #2394
Conversation
There was a problem hiding this comment.
I'm confused by this one. Shouldn't we still run the tests for the >7 versions of restify?
There was a problem hiding this comment.
Iirc there was a bug in 7 preventing it from running on versions of node > 16. They then fixed the issue in subsequent versions. I'll do some sleuthing but we're going to be updating the minimum version of restify to 11 in this release so it may be moot
There was a problem hiding this comment.
ok yea so from versions 7-9 they didn't support node 18+. restify/node-restify#1906
There was a problem hiding this comment.
Yeah, but the change in this PR is only testing pre-7 and doing so on Node.js >=18. Unless I just can't read this change and package.json correctly.
There was a problem hiding this comment.
right so restify worked on any node version up until 7. they broke it for any versions 18+ until 10. We will eventually remove the pre 7 tests but that'll be in a different ticket. Then we test on versions 10+ on 18+, that didn't change so the diff is hard to see the whole picture
Description
Removed Node 16 from CI, updated all relevant engine stanza
Related Issues
Closes #2313