ci: increase the limit of installs from 2 to a bigger number #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I was helping Amy refactor
@newrelic/test-utilitites. I noticed we manage 2 separate queues for running tests and installing packages within the test. The install limit is 1 but we set it to 2 and the test limit defaults to number of CPUs or in CI we default to 4 if not using the larger runner. However since the test is kicked off first then queues up the install, you'll have a discrepancy in waiting for concurrent test runs and it'll show awaiting. This PR increases the install limit to a larger number 100 which can't really go above the jobs limit but it should speed up the tests slighty as it's not queueing up installs of tests. I plan on removing this 2nd queue in test utils but wanted to get this out beforehand.