Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to generate release notes #1483

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

JcolemanNR
Copy link
Contributor

@JcolemanNR JcolemanNR commented Mar 24, 2023

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

This PR contains a script that generates release notes from a template. There are several components that are mocked out for when we do the final integration in github.

Here is some sample output when the script is run with the command ./generate_release_notes.sh v10.8.0:


subject: .NET agent
releaseDate: '2023-03-24'
version: 10.8.0
downloadLink: 'https://download.newrelic.com/dot_net_agent/latest_release'
features: ['Feature 1', 'Feature 2', 'Feature 3']
bugs: ['Bug 1', 'Bug 2', 'Bug 3']
security: ['Security 1', 'Security 2', 'Security 3']

New Relic recommends that you update the agent regularly and at a minimum every 3 months. Read more about [keeping your agent up to date](/docs/new-relic-solutions/new-relic-one/install-configure/update-new-relic-agent).

This release is supported for one year after its release date. For a full list of supported versions and their support periods, please see our EOL policy doc.

Changelog

Checksum

This is some sample checksum output!

Updating

Reviewer Checklist

  • Perform code review

@codecov-commenter
Copy link

Codecov Report

Merging #1483 (e3c784f) into main (a19addd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
- Coverage   72.98%   72.97%   -0.01%     
==========================================
  Files         408      408              
  Lines       25462    25462              
==========================================
- Hits        18583    18581       -2     
- Misses       6879     6881       +2     

see 1 file with indirect coverage changes

@chynesNR
Copy link
Member

Looks pretty good! Maybe these should live under the existing build folder?

jaffinito
jaffinito previously approved these changes Mar 27, 2023
Copy link
Member

@jaffinito jaffinito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaffinito
Copy link
Member

This is pointing at main currently, is should this point to a release branch?

@nr-ahemsath
Copy link
Member

Looks pretty good! Maybe these should live under the existing build folder?

Or perhaps the deploy folder?

@JcolemanNR
Copy link
Contributor Author

This is pointing at main currently, is should this point to a release branch?

As this doesn't interfere with anything, I think we are fine with this being in main

@JcolemanNR
Copy link
Contributor Author

Looks pretty good! Maybe these should live under the existing build folder?

Or perhaps the deploy folder?

I almost put this in the deploy folder, I'll move it.

@JcolemanNR JcolemanNR merged commit c8ffe0e into main Mar 28, 2023
@nr-ahemsath nr-ahemsath deleted the jc/release-notes-template branch January 4, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants