-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NLog to improve local log decoration coverage #1393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
- Coverage 71.62% 71.61% -0.01%
==========================================
Files 459 459
Lines 30619 30619
==========================================
- Hits 21932 21929 -3
- Misses 8687 8690 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like there are integration tests that exercise this code, but we need an item on our backlog to add the necessary assertions to validate this behavior.
I added a story to our backlog. |
Description
Changes how the NLog instrumentation updates the log message for local log decoration.
Caveats:
This does not 100% cover all the log lines. It does cover the vast majority of them.
Author Checklist
Reviewer Checklist