IIS Out of Process Instrumentation Fix #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsider that path when determining whether to instrument w3wp.exe
jaffinito
reviewed
Feb 17, 2023
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
JcolemanNR and
chynesNR
nr-ahemsath
requested changes
Feb 17, 2023
There was a problem hiding this comment.
A bit of "tribal knowledge" that I'm not sure is documented anywhere - when we make profiler changes, we need to build the profiler locally, and check in the new profiler binaries to this place in our repo: https://github.com/newrelic/newrelic-dotnet-agent/tree/main/src/Agent/_profilerBuild
There are four profiler binaries that need to be built and checked in: Windows 64 bit, Windows 32-bit, Linux x64, and Linux ARM64.
JcolemanNR
reviewed
Feb 17, 2023
chynesNR
reviewed
Feb 17, 2023
nrcventura
reviewed
Feb 21, 2023
nrcventura
reviewed
Feb 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
- Coverage 71.62% 71.61% -0.01%
==========================================
Files 459 459
Lines 30619 30619
==========================================
- Hits 21932 21929 -3
- Misses 8687 8690 +3
|
nrcventura
approved these changes
Feb 22, 2023
nr-ahemsath
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Looks good to me. Confirmed with @tippmar-nr that these changes were manually tested and produce the expected behavior. 🚢
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Updates profiler startup to look at both the current process name and the parent process name when deciding whether the process should be instrumented. For .NET Core Out of Process IIS hosted websites, the current process name is
dotnet.exeand the parent process name isw3wp.exe.This fix ensures that app pool instrumentation configuration in newrelic.config works for both regular and out of process websites.
Author Checklist
Reviewer Checklist