-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub workflows #1422
Update GitHub workflows #1422
Conversation
…move deprecated GHA commands.
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
Coverage 71.61% 71.61%
=======================================
Files 459 459
Lines 30631 30631
=======================================
Hits 21935 21935
Misses 8696 8696 |
It looks fine, but I think we either need to find a way to do some additional testing, or set aside extra time for the next release to make sure there aren't any surprises. |
@chynesNR So, with only a couple of exceptions, the changes in the workflows that I've been unable to test are simple version upgrades that are also mirrored in the workflows that I could test. I would agree that there is some risk with not testing these changes, but I think it's very low. Several of the workflows don't appear to be used at all, a couple are only seldomly used and the others seem to be related to the release process. I'll be happy to help with (or run) the next release and deal with any issues that might come up, though I'm confident there won't be any. Thoughts? |
Since the changes in the workflow files we haven't been able to test are so similar to the changes in the workflows we have been able to test, most importantly the all_solutions_build (main CI), I believe the risk in merging this is acceptable. Approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, verified that the green CI for this PR used the new workflow. 👍
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
::set-output
with proper usages of GitHub environment files.Note that I've only been able to test the changes to the following workflow files -- the others either aren't currently used or can't easily be tested due to the work they do (like deploying the agent):
all_solutions.yml
repolinter.yml
run_unit_tests.yml
Author Checklist
Performance testing completed with satisfactory results (if required)Agent Changelog or Lambda Agent changelog updatedReviewer Checklist