Provide optional automatic ledger/wallet backups before an upgrade #2198
Conversation
There was a problem hiding this comment.
For file names we could follow what was done in #1959 .
config.json -> config_backup_15571460497935531.json
|
@guilhermelawless imagine several data.ldb backups size |
|
That's a good point. Can we then follow some other convention, for example EDIT: We use |
|
I guess we can use config_backup_15571460497935531.json style for wallets (usually small size) & other for data.ldb |
Print error if backup creation was failed
|
Why wouldn't this happen by default? Many of us service operators have run into countless issues where something is corrupt after an upgrade and we have to start from scratch. Would be awesome if it could backup automatically then I suppose delete the backup once everything is successful and just make it optional to retain the backup post upgrade |
|
@schenkty All it takes is changing a config flag then you're set for every future upgrade |
|
Adding toml label as |
|
This will have to be changed as #2203 was merged which creates the new config upgrade path. |
guilhermelawless
added
the
documentation
with changes from PRs nanocurrency/nano-node#2198, nanocurrency/nano-node#2214
* Update config.json file with changes from PRs nanocurrency/nano-node#2198, nanocurrency/nano-node#2214 * Rewording
* TOML config file support and migration * Add config override support via a CLI option * Incorporate config changes from #2214 * Remove deprecation as this currently fails to compile on CI * Add default empty vector to read_node_config_toml * Make sure override streams are not empty * Adjust unit tests with changed base/override order * Incorporate config changes from #2198 and reorder some methods * httpcallback section, and documentation improvements * Clarify data type for wallet account, formatting * CI formatting * Improved node config unit test coverage, address review feedback * Full node and rpc config file coverage. Fix httpcallback deserialization. * Improve toml diff test * Use const ref in toml config, fix schema type for rpc_path * Incorporate work watcher period from #2222 * Add work_watcher_period validation as well as unit test
* Update config.json file with changes from PRs nanocurrency/nano-node#2198, nanocurrency/nano-node#2214 * Rewording
#1690