Configurable work watcher period #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
documentation
|
Are all timings in config currently in ms? |
|
I believe so, but documentation covers it. Do we need that much control? |
|
@SergiySW there are 2 instances of times in seconds: |
|
I guess we need check for it to not be 0? |
|
@guilhermelawless for the toml PR: could you attach a comment here with a suitable one-liner description of the new config option? No need to mention data type or default value as the toml file will contain those. |
cryptocode
approved these changes
Aug 19, 2019
|
@cryptocode it's best to refer to the nano-docs PR in case it changes. That's a one liner in the config documentation. |
SergiySW
approved these changes
Aug 19, 2019
cryptocode
added a commit
to cryptocode/raiblocks
that referenced
this pull request
Aug 20, 2019
cryptocode
added a commit
that referenced
this pull request
Aug 23, 2019
* TOML config file support and migration * Add config override support via a CLI option * Incorporate config changes from #2214 * Remove deprecation as this currently fails to compile on CI * Add default empty vector to read_node_config_toml * Make sure override streams are not empty * Adjust unit tests with changed base/override order * Incorporate config changes from #2198 and reorder some methods * httpcallback section, and documentation improvements * Clarify data type for wallet account, formatting * CI formatting * Improved node config unit test coverage, address review feedback * Full node and rpc config file coverage. Fix httpcallback deserialization. * Improve toml diff test * Use const ref in toml config, fix schema type for rpc_path * Incorporate work watcher period from #2222 * Add work_watcher_period validation as well as unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
work_watcher_perioddefaulting to 5 seconds.Also moved the
condition.waitto the end of the loop so thatstoppedis checked before going through blocks.