Backup config files when upgrading #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
documentation
argakiig
approved these changes
May 6, 2019
Yep good idea. It actually helped uncover a bug where the backup file is always created, even when creating a fresh one (not upgrading). Also got rid of an unnecessary template parameter declaration for the |
argakiig
approved these changes
May 9, 2019
zhyatt
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's reasonable practice to create backups of files which the user is allowed to modify if you are going to modify them. There were also multiple times during the v19 RC1 period where having the original config file beta testers were using before an upgrade would have been useful.
During any upgrades of the config a new file will be created, for instance:
config_backup_15571460497935531.jsonNote: It might look initially strange during upgrades from v18 as the new
rpc_config.jsonwill have an initial backup because the migration only copies things from the originalconfig.json, all the new options for the rpc are done in an upgrade. This can be added to documentation as expected behaviour.