Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide optional automatic ledger/wallet backups before an upgrade #1690

Closed
guilhermelawless opened this issue Feb 3, 2019 · 5 comments
Closed

Provide optional automatic ledger/wallet backups before an upgrade #1690

guilhermelawless opened this issue Feb 3, 2019 · 5 comments
Assignees
@SergiySW
Labels
enhancement
Milestone
V20.0

Comments

@guilhermelawless
Copy link
Contributor

QOL enhancement.

If upgrading the ledger, do a backup (controlled on/off via config, default off, and maybe change location via a launch flag). If upgrading the wallet, do the same.
@zhyatt zhyatt added this to the Research for Future Release milestone Feb 26, 2019
@guilhermelawless
Copy link
Contributor Author

Config backup was done here: #1959

@zhyatt
Copy link
Collaborator

zhyatt commented Jun 6, 2019

Closed by #1959

@zhyatt zhyatt closed this as completed Jun 6, 2019
@guilhermelawless
Copy link
Contributor Author

@zhyatt The issue was regarding ledger (data.ldb) and wallet (wallet.ldb) backups, before things like the cementing or sideband upgrade. But these should be less frequent over time I guess (maybe again for pruning?).

That said, an automatic config backup is a great feature.

@zhyatt
Copy link
Collaborator

zhyatt commented Jun 7, 2019

Wow, did I ever read that wrong. :) Reopening

@zhyatt zhyatt reopened this Jun 7, 2019
SergiySW added a commit to SergiySW/raiblocks that referenced this issue Aug 5, 2019
@SergiySW
Provide optional automatic ledger/wallet backups before an upgrade
a96df1a 
nanocurrency#1690
@SergiySW SergiySW mentioned this issue Aug 5, 2019
Merged
SergiySW added a commit that referenced this issue Aug 14, 2019
@SergiySW
Provide optional automatic ledger/wallet backups before an upgrade (#…
468a3f2 
…2198)

* Provide optional automatic ledger/wallet backups before an upgrade
#1690
* Add create_backup_file () function
Print error if backup creation was failed
* Log and cout message before DB backup
@guilhermelawless
Copy link
Contributor Author

Closed by #2198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergiySW SergiySW

Labels
enhancement
Projects
None yet
Milestone
V20.0
Development

No branches or pull requests
3 participants
@zhyatt @guilhermelawless @SergiySW