Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal has no response to typing on Codespace #165416

Closed
rongxin-liu opened this issue Nov 3, 2022 · 11 comments
Closed

Terminal has no response to typing on Codespace #165416

rongxin-liu opened this issue Nov 3, 2022 · 11 comments
Assignees
Labels
ios-ipados safari Issues running VSCode in Web on Safari terminal-rendering
Milestone

Comments

@rongxin-liu
Copy link

rongxin-liu commented Nov 3, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.73.0 (8fa188b)
  • OS Version: Browser: Mozilla/5.0 (iPad; CPU OS 15_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/107.0.5304.66 Mobile/15E148 Safari/604.1

Steps to Reproduce:

  1. Open iPad (iOS 15.7)
  2. Run Chrome or Safari
  3. Access Codespace
  4. Tap on terminal and start typing

We had received many reports indicating having terminal issues (no response to typing) on Codespaces, and it seemed only Safari users were affected. Though I could not reproduce this issue on my macOS (12.6) running Safari (Version 16.0), I was able to reliably reproduce this issue on an iPad running both Safari and Chrome.

Concretely, when users start typing in the terminal, the terminal has no visual feedback as if it wouldn't take any user input. However, the terminal was still taking user input, and one could still execute commands (just all the texts typed in were "hidden")

Here is a recording of the issue:

RPReplay_Final1667503328.MP4

I was typing commands such as code hello.py and python3, and the command would run, just no visual response on the terminal.

@rongxin-liu
Copy link
Author

Related issues:
#165381
#165370
#165338
#165316
#165310
#165290

@meganrogge
Copy link
Contributor

does changing terminal.integrated.gpuAcceleration help?

@meganrogge meganrogge added info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label safari Issues running VSCode in Web on Safari ios-ipados terminal-rendering and removed terminal General terminal issues that don't fall under another label labels Nov 3, 2022
@rongxin-liu
Copy link
Author

does changing terminal.integrated.gpuAcceleration help?

Turning off terminal.integrated.gpuAcceleration did address the issue.

@meganrogge
Copy link
Contributor

meganrogge commented Nov 3, 2022

depending on the safari version, gpu acceleration is unsupported

@meganrogge meganrogge removed the info-needed Issue requires more information from poster label Nov 3, 2022
@rongxin-liu
Copy link
Author

rongxin-liu commented Nov 3, 2022

Some Chrome users also ran into the same issues on their devices (macOS/iOS). Turning off GPU acceleration for the terminal seemed okay for now.

@dascope
Copy link

dascope commented Nov 4, 2022

Thanks @meganrogge. FYI it worked fine on iPad Air (4th Gen) iOS 14.6 until two days ago, with gpu acceleration enabled. Disabling gpu acceleration now fixes it on this device as well.

@meganrogge
Copy link
Contributor

We should investigate if there's a way to check browser IE safari and version IE 15 and if so, disable gpu acceleration

@jeanp413
Copy link
Contributor

jeanp413 commented Nov 7, 2022

isn't this handled by this already 🤔
Ah this is related to canvas renderer

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 8, 2022
This does not fix the issue where webkit browsers cannot use it, I looked
at webkit versions in safari and was a bit confused. The wikipedia page
for safari shows v15 having webkit v612+ but I have safari v16 and it's
webkit v605, so trying to detect it based on webkit version is a risky
change.

Fixes xtermjs#3357
Related xtermjs#3575
Related microsoft/vscode#165416
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 8, 2022
This does not fix the issue where webkit browsers cannot use it, I looked
at webkit versions in safari and was a bit confused. The wikipedia page
for safari shows v15 having webkit v612+ but I have safari v16 and it's
webkit v605, so trying to detect it based on webkit version is a risky
change.

Note that webgl2 shipped in safari 15, but it didn't work in webgl until
safari 16.

Fixes xtermjs#3357
Related xtermjs#3575
Related microsoft/vscode#165416
This was referenced Nov 9, 2022
@Tyriar
Copy link
Member

Tyriar commented Nov 23, 2022

I believe this is fixed with the last xterm update, if not it will be in the one today when it's updated for #166158

@Tyriar Tyriar closed this as completed Nov 23, 2022
@Tyriar Tyriar added this to the November 2022 milestone Nov 23, 2022
@RexBlock
Copy link

RexBlock commented Dec 6, 2022

Turning off terminal.integrated.gpuAcceleration did address the issue.

Where is this setting applied?

Thanks.

@Tyriar
Copy link
Member

Tyriar commented Dec 6, 2022

@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios-ipados safari Issues running VSCode in Web on Safari terminal-rendering
Projects
None yet
Development

No branches or pull requests

7 participants