-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal has no response to typing on Codespace #165416
Comments
does changing |
Turning off |
depending on the safari version, gpu acceleration is unsupported |
Some Chrome users also ran into the same issues on their devices (macOS/iOS). Turning off GPU acceleration for the terminal seemed okay for now. |
Thanks @meganrogge. FYI it worked fine on iPad Air (4th Gen) iOS 14.6 until two days ago, with gpu acceleration enabled. Disabling gpu acceleration now fixes it on this device as well. |
We should investigate if there's a way to check browser IE safari and version IE 15 and if so, disable gpu acceleration |
|
This does not fix the issue where webkit browsers cannot use it, I looked at webkit versions in safari and was a bit confused. The wikipedia page for safari shows v15 having webkit v612+ but I have safari v16 and it's webkit v605, so trying to detect it based on webkit version is a risky change. Fixes xtermjs#3357 Related xtermjs#3575 Related microsoft/vscode#165416
This does not fix the issue where webkit browsers cannot use it, I looked at webkit versions in safari and was a bit confused. The wikipedia page for safari shows v15 having webkit v612+ but I have safari v16 and it's webkit v605, so trying to detect it based on webkit version is a risky change. Note that webgl2 shipped in safari 15, but it didn't work in webgl until safari 16. Fixes xtermjs#3357 Related xtermjs#3575 Related microsoft/vscode#165416
I believe this is fixed with the last xterm update, if not it will be in the one today when it's updated for #166158 |
Where is this setting applied? Thanks. |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
We had received many reports indicating having terminal issues (no response to typing) on Codespaces, and it seemed only Safari users were affected. Though I could not reproduce this issue on my macOS (12.6) running Safari (Version 16.0), I was able to reliably reproduce this issue on an iPad running both Safari and Chrome.
Concretely, when users start typing in the terminal, the terminal has no visual feedback as if it wouldn't take any user input. However, the terminal was still taking user input, and one could still execute commands (just all the texts typed in were "hidden")
Here is a recording of the issue:
RPReplay_Final1667503328.MP4
I was typing commands such as
code hello.py
andpython3
, and the command would run, just no visual response on the terminal.The text was updated successfully, but these errors were encountered: