Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearance of characters and whole lines when opening multiple terminals #166158

Closed
imblowfish opened this issue Nov 11, 2022 · 14 comments · Fixed by xtermjs/xterm.js#4271 or #167080
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone

Comments

@imblowfish
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.73.1
  • OS Version: Ubuntu 22.04

Steps to Reproduce:

  1. Open multiple terminals
  2. Go to last created, write something
  3. Go to any other than the last one
  4. Write the beginning of a command and press tab for autocompletion

After a while, the characters reappear if you run any command again.

I found this issue #165969, but according to the description it is not entirely clear which input the author means

Here is what I was able to reproduce (In each terminal I enter the same command cd ~/ and press Tab):

Screenshot from 2022-11-12 02-46-20

Screenshot from 2022-11-12 02-56-28

@meganrogge
Copy link
Contributor

I cannot repro on mac, maybe something has been fixed?

@meganrogge
Copy link
Contributor

also can't repro on WSL

@meganrogge
Copy link
Contributor

I believe this is already fixed, can you see if you can reproduce in the Insiders build?
/label info-needed

@vscodenpa vscodenpa added the info-needed Issue requires more information from poster label Nov 14, 2022
@imblowfish
Copy link
Author

Hi @meganrogge, I don't know if the problem occurs on MacOS
I tried to reproduce this error in the Insider build (Visual Studio Code CLI 1.74.0) and got the same result.
image

@imblowfish
Copy link
Author

I also recorded a video of how I reproduced the bug, I hope this helps
https://user-images.githubusercontent.com/28269602/201778687-bd080f1b-daf4-40cb-852a-684801400b16.mp4

@ZeroOnePro
Copy link

issue #165969

I saw your problem and it seems that there is something different from mine.

The problem with me was that if I first run the vscode after booting and type in my native language, Korean, some letters disappeared from the input.

There is no problem when typing in English.

For example, if I type '가나다라마바사' in a markdown or any file, some of the inputs disappear and become '가나라바사'.

It disappears even though I typed "다, 마"

@imblowfish Isn't your problem that the terminal input disappears?

@ZeroOnePro
Copy link

@meganrogge Is this issue the same as the issue I opened? #165969

@imblowfish
Copy link
Author

issue #165969

I saw your problem and it seems that there is something different from mine.

The problem with me was that if I first run the vscode after booting and type in my native language, Korean, some letters disappeared from the input.

There is no problem when typing in English.

For example, if I type '가나다라마바사' in a markdown or any file, some of the inputs disappear and become '가나라바사'.

It disappears even though I typed "다, 마"

@imblowfish Isn't your problem that the terminal input disappears?

Hi @ZeroOnePro, I think not, my problem is reproduced only in the terminal, there are no problems in the files.

@ZeroOnePro
Copy link

Hi @imblowfish

I wonder if the cause of your problem and the cause of my problem are the same.

What's your idea?

@imblowfish
Copy link
Author

Hi @imblowfish

I wonder if the cause of your problem and the cause of my problem are the same.

What's your idea?

Can't say with certainty

@meganrogge
Copy link
Contributor

Different issues, thanks for the additional info

@Tyriar
Copy link
Member

Tyriar commented Nov 18, 2022

Happened to me just now:

image

webgl renderer
Version: 1.74.0-insider (user setup)
Commit: 1b1e2a2
Date: 2022-11-18T05:25:18.342Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

@jeanp413
Copy link
Contributor

Created a PR fixing it xtermjs/xterm.js#4271

jeanp413 added a commit to jeanp413/xterm.js that referenced this issue Nov 22, 2022
@Tyriar Tyriar added this to the November 2022 milestone Nov 23, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream and removed info-needed Issue requires more information from poster labels Nov 23, 2022
@Tyriar Tyriar reopened this Nov 23, 2022
Tyriar added a commit that referenced this issue Nov 23, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 23, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@connor4312
Copy link
Member

I saw sometimes, though I never found a reproduction for it. However I have not seen it this week, thus marking verified.

@connor4312 connor4312 added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
7 participants