Added Source Code and Send Feedback buttons to About dialog #13510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-UserInterface
|
Is there a reason this is still in draft? This looks good to me 😄 |
AdamSotak
force-pushed
the
about-dialog-interface-update
branch
3 times, most recently
from
48460b0 to
9ac9f45
Compare
|
I realized that I could add one more string to the resource file. Changing PR to Ready for review after checks complete. |
AdamSotak
force-pushed
the
about-dialog-interface-update
branch
from
9ac9f45 to
aebf2bd
Compare
zadjii-msft
approved these changes
Jul 18, 2022
|
(you may need to run |
AdamSotak
force-pushed
the
about-dialog-interface-update
branch
from
aebf2bd to
405b526
Compare
lhecker
approved these changes
Jul 18, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
3 tasks
pull bot
pushed a commit
to Xen0byte/terminal
that referenced
this pull request
Aug 18, 2022
We shouldn't add URLs into our binaries that we can't directly control. This commit fixes the issue for URLs recently introduced in microsoft#13510. Closes microsoft#13541 ## Validation Steps Performed This change is trivial enough that I simply opened the new redirects in my browser, ensuring that they open the expected websites.
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added two new buttons to the About dialog. Source Code and Send Feedback buttons link directly to the Terminal project on GitHub and to the Issues page respectively.
References
#13371
PR Checklist
Validation Steps Performed
Performed manual testing and confirmed that the implementation works.