Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] Update Feedback link to be a fwlink #13541

Closed
3 tasks
zadjii-msft opened this issue Jul 19, 2022 · 0 comments · Fixed by #13759
Closed
3 tasks

[1.16] Update Feedback link to be a fwlink #13541

zadjii-msft opened this issue Jul 19, 2022 · 0 comments · Fixed by #13759
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.16

Comments

@zadjii-msft
Copy link
Member

Follow up to #13510:

  • Update Feedback link to be a fwlink
  • Update source code link to be a fwlink
  • and make two versions, one for Preview, and one for Stable

We'll need to do this on our side, as we control the fwlinks
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Jul 19, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 19, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 20, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 26, 2022
@lhecker lhecker mentioned this issue Aug 16, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 16, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 18, 2022
pull bot pushed a commit to Xen0byte/terminal that referenced this issue Aug 18, 2022
@lhecker
Use the redirection service for recently added URLs (microsoft#13759)
9f9f5de 
We shouldn't add URLs into our binaries that we can't directly control.
This commit fixes the issue for URLs recently introduced in microsoft#13510.

Closes microsoft#13541

## Validation Steps Performed
This change is trivial enough that I simply opened the new redirects
in my browser, ensuring that they open the expected websites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

Use the redirection service for recently added URLs microsoft/terminal
1 participant
@zadjii-msft