Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the redirection service for recently added URLs #13759

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Aug 16, 2022

We shouldn't add URLs into our binaries that we can't directly control.
This commit fixes the issue for URLs recently introduced in #13510.

Closes #13541

Validation Steps Performed

This change is trivial enough that I simply opened the new redirects
in my browser, ensuring that they open the expected websites.

@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Aug 16, 2022
Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
@zadjii-msft
Copy link
Member

@msftbot merge this in 5.512345 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 30 Aug 2022 19:11:32 GMT, which is in 14 days (that is as long as I can help with delaying the merge)

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 16, 2022

damn just take a joke for once

@msftbot merge this in 2 minutes

okay so if you don't start with the "@msftbot" it just ignores you

@DHowett
Copy link
Member

DHowett commented Aug 16, 2022

LOL.

@zadjii-msft
Copy link
Member

@msftbot merge this in 2 minutes

@ghost
Copy link

ghost commented Aug 16, 2022

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 16 Aug 2022 19:16:28 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost
Copy link

ghost commented Aug 16, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Aug 18, 2022
@ghost ghost requested review from PankajBhojwani and carlos-zamora August 18, 2022 11:36
@carlos-zamora carlos-zamora merged commit 9f9f5de into main Aug 18, 2022
@carlos-zamora carlos-zamora deleted the dev/lhecker/13541-fwlinks branch August 18, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.16] Update Feedback link to be a fwlink
4 participants