Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No GitHub/Feedback link in About box. #13371

Closed
michael-hawker opened this issue Jun 23, 2022 · 6 comments · Fixed by #13510
Closed

No GitHub/Feedback link in About box. #13371

michael-hawker opened this issue Jun 23, 2022 · 6 comments · Fixed by #13510
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@michael-hawker
Copy link

Description of the new feature/enhancement

The current about dialog is pretty simple:

image

It'd be nice to see:

  • Terminal Icon
  • A link to GitHub (maybe w/ GitHub Icon)
  • A 'Send Feedback' link which leads here or Feedback Hub:
    image
@michael-hawker michael-hawker added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 23, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 23, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 23, 2022
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. good first issue This is a fix that might be easier for someone to do as a first contribution labels Jul 5, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 5, 2022
@zadjii-msft
Copy link
Member

FWIW We used to have this in the top level dropdown, but it was just generating noise.

In #789 we made it point at our GitHub issues, but at some point after that we redirected that to the FeedbackUriValue resource, which redirects to feedback hub now.

We've discussed offline the idea of putting this back somewhere, once again pointing at GitHub, and again with the in-app-feedback label (or something like that). Of course, we can just change the fwlink on our side to point at whatever, so just adding a link back should be easy enough.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 5, 2022
@AdamSotak
Copy link
Contributor

Hello, I would like to work on this.

I have already implemented these buttons:

WindowsTerminalAboutDialog

The buttons link directly to:

I would appreciate your feedback.

@zadjii-msft
Copy link
Member

I think that would be perfect! Honestly, GitHub is a way better place for feedback than Feedback Hub 😄

@DHowett
Copy link
Member

DHowett commented Jul 14, 2022

This might be one of those things where the stable version should direct users to the feedback hub, and the preview/dev versions should direct users to GitHub . . . @zadjii-msft, WDYT?

Motivation: I don't know if, when we become "DxD", we can rely on the large population of Stable users to have GitHub accounts.

@zadjii-msft
Copy link
Member

That's a good idea, but let's start small. Let's just start with the links as @AdamSotak has it now for now, and we can sort out the fwlinks on our side in post.

@AdamSotak AdamSotak mentioned this issue Jul 14, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 14, 2022
@ghost ghost closed this as completed in #13510 Jul 19, 2022
ghost pushed a commit that referenced this issue Jul 19, 2022
@AdamSotak
Added Source Code and Send Feedback buttons to About dialog (#13510)
e7a79d9 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Added two new buttons to the About dialog. Source Code and Send Feedback buttons link directly to the Terminal project on GitHub and to the Issues page respectively.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References
#13371

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [ ] Closes #13371
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #13371

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Performed manual testing and confirmed that the implementation works.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 19, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13510, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Added Source Code and Send Feedback buttons to About dialog AdamSotak/terminal
4 participants
@DHowett @zadjii-msft @michael-hawker @AdamSotak