Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Feedback link to take you to github #789

Merged
merged 1 commit into from
May 14, 2019

Conversation

zadjii-msft
Copy link
Member

Fixes #787.

Considering we're just duping all feedback hub issues to github, lets cut out
the middleman and take them straight here.

  Fixes #787.

  Considering we're just duping all feedback hub issues to github, lets cut out
  the middleman and take them straight here.
@zadjii-msft zadjii-msft requested review from DHowett-MSFT and a team May 14, 2019 18:34
@carlos-zamora
Copy link
Member

Maybe a little nitpicky but thoughts on cutting out an extra step and going to "https://github.com/microsoft/Terminal/issues/new"?

@adiviness
Copy link
Contributor

Maybe a little nitpicky but thoughts on cutting out an extra step and going to "https://github.com/microsoft/Terminal/issues/new"?

I have no strong feelings one way or the other.

@miniksa
Copy link
Member

miniksa commented May 14, 2019

Maybe a little nitpicky but thoughts on cutting out an extra step and going to "https://github.com/microsoft/Terminal/issues/new"?

I have two feelings about it:

  1. Dropping people onto the main page might offer them the opportunity to read the issues before writing a new one.
  2. I think the new issue form will offer them our templates and automatically try to find duplicates these days, so it might be a good call to go there.

I want @DHowett-MSFT to weigh in on this before merge though.

@DHowett-MSFT
Copy link
Contributor

So the way it is today most closely mimics what we had before: dropping people onto the "feedback portal" where they can find everything. It's probably better for discovery than using the New Issues page.

If they can't find what they're about to report, "new issue" is just one click away. If they submit new feedback and github suggests the dupe they couldn't find, that's another chance to get them to +1 an existing report.

@miniksa
Copy link
Member

miniksa commented May 14, 2019

OK let's roll with this then.

@miniksa miniksa merged commit b5eeddf into master May 14, 2019
@miniksa miniksa deleted the dev/migrie/b/787-feedback-link branch May 14, 2019 20:17
ObsidianPhoenix pushed a commit to ObsidianPhoenix/Terminal that referenced this pull request May 15, 2019
Fixes microsoft#787.

  Considering we're just duping all feedback hub issues to github, lets cut out
  the middleman and take them straight here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Feedback link to go to GitHub
5 participants