Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn analyzer for NativeModuleBase #2

Closed
rozele opened this issue Dec 15, 2015 · 1 comment
Closed

Roslyn analyzer for NativeModuleBase #2

rozele opened this issue Dec 15, 2015 · 1 comment
Milestone
Developer Experience

Comments

@rozele
Copy link
Collaborator

rozele commented Dec 15, 2015

Write an analyzer that ships with the ReactWindows NuGet package that will give compile time checks for things like function name overloads.
@rozele rozele added this to the V1 Core milestone Dec 15, 2015
@rozele rozele removed this from the V1 Core milestone Dec 15, 2015
@rozele rozele added this to the Core Framework - V1 milestone Feb 18, 2016
@rozele rozele added large and removed enhancement labels Feb 18, 2016
@rozele rozele modified the milestones: Developer Support, Core Framework - V1 Feb 18, 2016
ebragge added a commit that referenced this issue Mar 14, 2016
@ebragge
feat(AsyncStorageModule): add AsyncStorageModule
9eb5adf 
AsyncStorageModule provides permanent storage for React Native JavaScript applications.
- implement PR comments #2
- add Android tests

Fixes #136
ebragge added a commit that referenced this issue Mar 21, 2016
@ebragge
feat(ReactPickerView): Add ReactPickerView
d3a79b3 
ReactPicker provides access to native selector UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes #231
rozele pushed a commit that referenced this issue Apr 21, 2016
@ebragge @rozele
feat(AsyncStorageModule): add AsyncStorageModule
2375462 
AsyncStorageModule provides permanent storage for React Native JavaScript applications.
- implement PR comments #2
- add Android tests

Fixes #136
rozele pushed a commit that referenced this issue Apr 21, 2016
@ebragge @rozele
feat(ReactPickerView): Add ReactPickerView
6f0c481 
ReactPicker provides access to native selector UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes #231
ebragge added a commit that referenced this issue Apr 25, 2016
@ebragge
fix(ReactWebView): Add ReactWebView
028b6b1 
ReactWebView provides access to native webview UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes #118
rozele pushed a commit that referenced this issue May 17, 2016
@ebragge @rozele
feat(AsyncStorageModule): add AsyncStorageModule
f3506fc 
AsyncStorageModule provides permanent storage for React Native JavaScript applications.
- implement PR comments #2
- add Android tests

Fixes #136
rozele pushed a commit that referenced this issue May 17, 2016
@ebragge @rozele
feat(ReactPickerView): Add ReactPickerView
0c546d0 
ReactPicker provides access to native selector UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes #231
rozele pushed a commit that referenced this issue May 17, 2016
@ebragge @rozele
fix(ReactWebView): Add ReactWebView
6b99170 
ReactWebView provides access to native webview UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes #118
rozele pushed a commit that referenced this issue May 18, 2016
@ebragge @rozele
feat(AsyncStorageModule): add AsyncStorageModule
7e9bb7e 
AsyncStorageModule provides permanent storage for React Native JavaScript applications.
- implement PR comments #2
- add Android tests

Fixes #136
@rozele rozele self-assigned this Jun 30, 2016
@rozele rozele added ready and removed ready labels Jun 30, 2016
@rozele rozele removed their assignment Jun 30, 2016
GantMan referenced this issue in infinitered/react-native-windows Sep 29, 2016
@ebragge @GantMan
feat(AsyncStorageModule): add AsyncStorageModule
23d0315 
AsyncStorageModule provides permanent storage for React Native JavaScript applications.
- implement PR comments #2
- add Android tests

Fixes microsoft#136
GantMan referenced this issue in infinitered/react-native-windows Sep 29, 2016
@ebragge @GantMan
feat(ReactPickerView): Add ReactPickerView
60e3047 
ReactPicker provides access to native selector UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes microsoft#231
GantMan referenced this issue in infinitered/react-native-windows Sep 29, 2016
@ebragge @GantMan
fix(ReactWebView): Add ReactWebView
35f7464 
ReactWebView provides access to native webview UI components for React Native JavaScript applications.
- PR comments #2 implemented

Fixes microsoft#118
rozele pushed a commit that referenced this issue Feb 7, 2017
@jpshelley @facebook-github-bot
BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public #2
f824643 
Summary:
AaaChiuuu
See: facebook/react-native#11329
Closes facebook/react-native#11505

Differential Revision: D4338559

Pulled By: AaaChiuuu

fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
@anttilehtonen anttilehtonen mentioned this issue Mar 20, 2018
Closed
@rozele
Copy link
Collaborator Author

rozele commented Jul 23, 2018

Closing due to age of issue. Will re-open if there is interest in this.

@rozele rozele closed this as completed Jul 23, 2018
@pre10der89 pre10der89 mentioned this issue Jul 27, 2018
Closed
randy-flynn added a commit that referenced this issue Mar 26, 2019
@randy-flynn
Merge pull request #2 from Microsoft/rnwcpp-preview
1ce9127 
Rnwcpp preview
@kikisaints kikisaints mentioned this issue May 20, 2019
Closed
@kmelmon kmelmon mentioned this issue Jul 31, 2019
Merged
kmelmon referenced this issue in kmelmon/react-native-windows Oct 21, 2019
@kmelmon
try #2 at getting the right publish path
8e0189f
kmelmon added a commit that referenced this issue Oct 22, 2019
@kmelmon
Capture detailed logs from CI loop (#3464)
d203df0 
* merge

* Change files

* always publish binlog, comment out targets

* comment out targets

* change to succeededOrFailed.  Of course!

* move condition outside inputs.  Of course!

* add more binlogs

* tweak path

* joy!  reverse engineering pathToPublish is fun

* sheesh. still trying to find the binlog

* use Build.SourcesDirectory to locate binlog

* typo

* giving up on /bl.  Trying another option

* publish log

* add timeout

* log more build jobs

* change publish path

* try #2 at getting the right publish path

* remove clean
@chrisglein chrisglein mentioned this issue Nov 4, 2019
Closed
@NickGerleman NickGerleman mentioned this issue Nov 12, 2019
Closed
@ddalp ddalp mentioned this issue Feb 18, 2020
Merged
@kmelmon kmelmon mentioned this issue Apr 23, 2020
Closed
@kmelmon kmelmon mentioned this issue Aug 17, 2020
Closed
kmelmon added a commit that referenced this issue Aug 18, 2020
@kmelmon
Re-enable VisitAllPages E2ETest (#5699)
4174941 
* re-enable

* comment out PlatformColor test, this was the failing test in the past as well

* trying again, this time commenting out PanResponder Sample, which comes just before the failing test

* trying to wait for home page to load before continuing

* another take on waiting for item in FlatList to be loaded first

* trying new approach, enter test name in edit box to filter first

* made some progress, now timing out on edit control, add polling for that control

* finally!  success.  Try #2

* try #3, fingers crossed!

* try #4

* split test into groups

* bumping up timeout

* try #2 with longer timeout

* go back to one testspec

* try #4 with longer timeout

* try #5 with longer timeout.  really folks I think I got it this time :)

* convert all the tests to use same mechanism

* Change files

* remove smoke test

* stability pass after removing smoke test, try #2
@kmelmon kmelmon mentioned this issue Aug 24, 2020
Merged
rectified95 referenced this issue in rectified95/react-native-windows Oct 6, 2020
blur focus #2
61d281f
rectified95 referenced this issue in rectified95/react-native-windows Oct 8, 2020
blur focus #2
5e7d097
@NickGerleman NickGerleman mentioned this issue Oct 22, 2021
Closed
@chrisglein chrisglein mentioned this issue Jun 6, 2024
Closed
@slswalker slswalker mentioned this issue Jun 19, 2024
Merged
@slswalker slswalker mentioned this issue Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Developer Experience
Development

No branches or pull requests
1 participant
@rozele