Scroll viewer layoutbug #2859
Merged
Scroll viewer layoutbug #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addressing issue #2642 |
kmelmon
reviewed
Jul 31, 2019
ghost
added
Needs: Author Feedback
kmelmon
reviewed
Aug 2, 2019
kmelmon
reviewed
Aug 2, 2019
licanhua
reviewed
Aug 2, 2019
kmelmon
reviewed
Aug 8, 2019
kmelmon
pushed a commit
to kmelmon/react-native-windows
that referenced
this pull request
Aug 16, 2019
* Moving picker fix * Add controls to vector and check ShadowNode func needsForceLayout * Clear m_needsForceLayout between calls to DoLayout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the spot fix introduced by #2584 to NativeUIManager's UpdateExtraLayout method so that it can be applied to any control introduced to the tree in case similar bugs would be introduced by controls other than ScrollViewer/Picker. UpdateLayout will now be run on controls at the time that DoLayout is called from onBatchComplete. This should allow the controls to evaluate their final size before the rest of the layout is finished.
Microsoft Reviewers: Open in CodeFlow