Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public #2 #11505

Closed

Conversation

jpshelley
Copy link
Contributor

@AaaChiuuu
See: #11329

…DevSupportPublic

* upstream/master:
  Allow configuring the way CLI installs react-native
…DevSupportPublic

* upstream/master:
  Rename directories
  Use absolute paths from repo root
  Remove init from api
  CLI: Show npm / yarn output during 'react-native-init' when installing React and Jest
* master:
  Implement onViewAppear by creating a new EventListener on ReactRootView listening for when it's attached to a RN Instance
@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @foghina and @funorpain to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Dec 16, 2016
@facebook-github-bot
Copy link
Contributor

@AaaChiuuu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@AaaChiuuu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added GH Review: accepted CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed GH Review: review-needed labels Dec 16, 2016
@jpshelley jpshelley deleted the android-AllowHostDevSupportPublic branch December 16, 2016 15:14
DanielMSchmidt pushed a commit to DanielMSchmidt/react-native that referenced this pull request Jan 4, 2017
Summary:
AaaChiuuu
See: facebook#11329
Closes facebook#11505

Differential Revision: D4338559

Pulled By: AaaChiuuu

fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
@jpshelley
Copy link
Contributor Author

jpshelley commented Jan 10, 2017

@AaaChiuuu This didn't make it into 0.40.0, is it slated for 0.41.0?

Disregard, just saw: https://github.com/facebook/react-native/releases/tag/v0.41.0-rc.0

rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Feb 7, 2017
Summary:
AaaChiuuu
See: facebook/react-native#11329
Closes facebook/react-native#11505

Differential Revision: D4338559

Pulled By: AaaChiuuu

fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
AaaChiuuu
See: facebook/react-native#11329
Closes facebook/react-native#11505

Differential Revision: D4338559

Pulled By: AaaChiuuu

fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants