Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend react-native-link command #2

Closed
lukewalczak opened this issue Sep 28, 2018 · 1 comment
Closed

Extend react-native-link command #2

lukewalczak opened this issue Sep 28, 2018 · 1 comment
Labels
backlog This issue or pull request already exists command: link wontfix This will not be worked on

Comments

@lukewalczak
Copy link
Contributor

My suggestion/improvement for react-native-link command is to add an option to specify where new pod line should be added.

Why will you need it?

Let's say you have a project with multiple targets and multiple pods divided in some section like below:

def react_native_pods() 
  pod 'React', path: '../node_modules/react-native', subspecs: [
    'Core',
    'RCTActionSheet',
    'RCTAnimation',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket',
    'CxxBridge',
    'DevSupport',
  ]

  pod 'yoga', path: '../node_modules/react-native/ReactCommon/yoga/yoga.podspec'
  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
end

def customized_pods()
  pod 'react-native-maps', path: '../node_modules/react-native-maps'
end

target 'myFirstTarget' do
 react_native_pods()
end

target 'secondTarget' do
 react_native_pods()
 customized_pods()
end

Now if you are going to link new library eg. react-native-screens it would be awesome to have an option to indicate to which def section new pod line should be added.

@grabbou grabbou added backlog This issue or pull request already exists planned feature and removed enhancement labels Jan 16, 2019
Esemesek added a commit that referenced this issue Mar 18, 2019
@grabbou
Copy link
Member

grabbou commented Apr 3, 2019

I am going to close this issue and label as a "wont fix". New auto linking mechanism will have this solved by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This issue or pull request already exists command: link wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants