Maintenance: create headless-git.exe to avoid foreground windows #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
tentative/vfs-2.30.0
branch
from
f6c7e55
to
5fc9c4a
Compare
|
Good idea! This shows two problems, one in the minimal Git artifact (I think), and the other in the vs-build part (where I did not make the necessary adjustments to build |
dscho
added a commit
to git-for-windows/git-sdk-64
that referenced
this pull request
Dec 24, 2020
The `-lcomdlg32` option is implied by `-mwindows`. This is needed for microsoft/git#304. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I'll continue playing with this later. |
dscho
force-pushed
the
headless-git
branch
3 times, most recently
from
9e91eb4
to
27ef221
Compare
|
@derrickstolee I'm happy to report that I got the build green (finally!). |
dscho
force-pushed
the
tentative/vfs-2.30.0
branch
from
dc86de5
to
3bc657f
Compare
On Windows, there are two kinds of executables, console ones and non-console ones. Git's executables are all console ones. When launching the former e.g. in a scheduled task, a CMD window pops up. This is not what we want for the tasks installed via the `git maintenance` command. To work around this, let's introduce `headless-git.exe`, which is a non-console program that does _not_ pop up any window. All it does is to re-launch `git.exe`, suppressing that console window, passing through all command-line arguments as-are. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We just introduced a helper to avoid showing a console window when the scheduled task runs `git.exe`. Let's actually use it. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
derrickstolee
force-pushed
the
headless-git
branch
from
27ef221
to
a7b10df
Compare
|
Needed to add 12fd7fa because an encoding mismatch caused |
|
@jeffhostetler I could use your help here. I get the following BUG with my Scalar repos when running the maintenance this way: I'm sure it's related to my commit making maintenance care about Edit: I added a90be59 as a potential workaround. |
|
i think it is fine to remove the check. i shouldn't have used strcmp() there anyway. or rather, should have normalized probably both args first (to get the same type of slashes). besides, the second BUG would have crashed it the structure arg was null. thanks |
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
headless-git
branch
from
a90be59
to
6d020f0
Compare
This was referenced Dec 31, 2020
|
Interesting that I can't re-target this PR after its initial target was deleted. I'll leave it closed until we have a final upstream version to merge in. |
Ooops. I had not even realized that I closed this PR. 🤦 |
4 tasks
derrickstolee
commented
Jan 14, 2021
|
|
||
| if (!gh_client__chosen_odb || | ||
| strcmp(v1_odb_path, gh_client__chosen_odb->path)) | ||
| BUG("verify_odb_line: unexpeced odb path '%s' vs '%s'", |
There was a problem hiding this comment.
@jeffhostetler @dscho I hit this BUG during one of the functional tests near the end of the Scalar release build process so I'm going to cherry-pick this on top of vfs-2.30.0.
derrickstolee
added a commit
that referenced
this pull request
Jan 14, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
Mar 5, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
Mar 8, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
jeffhostetler
pushed a commit
that referenced
this pull request
Mar 15, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
jeffhostetler
pushed a commit
that referenced
this pull request
Mar 16, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
derrickstolee
added a commit
that referenced
this pull request
May 17, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
derrickstolee
added a commit
that referenced
this pull request
May 17, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
derrickstolee
added a commit
that referenced
this pull request
May 17, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
dscho
pushed a commit
that referenced
this pull request
May 21, 2021
This check verifies that the ODB matches what we supplied, but there are some subtleties around Windows path names that can cause inexact matches to be logically the same. Since this check is really intended only for debugging and development purposes, let's remove it for now as a quick workaround. This was originally part of #304, as I hit it more often in that effort. However, this was hit during the Scalar release process, so I'll need to generate new installers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits pulled from @dscho's derrickstolee#14.
This PR exists to more easily generate a Windows installer to check the whole flow.