Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gvfs-helper-client: remove odb check #306

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

derrickstolee
Copy link
Collaborator

This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.

This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@derrickstolee derrickstolee merged commit 7cd9573 into microsoft:vfs-2.30.0 Jan 14, 2021
derrickstolee added a commit to microsoft/scalar that referenced this pull request Jan 14, 2021
derrickstolee added a commit to microsoft/scalar that referenced this pull request Jan 14, 2021
derrickstolee added a commit to microsoft/VFSForGit that referenced this pull request Jan 15, 2021
dscho pushed a commit that referenced this pull request Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
dscho pushed a commit that referenced this pull request Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
dscho pushed a commit that referenced this pull request Mar 4, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
dscho pushed a commit that referenced this pull request Mar 5, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
dscho pushed a commit that referenced this pull request Mar 8, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
jeffhostetler pushed a commit that referenced this pull request Mar 15, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
jeffhostetler pushed a commit that referenced this pull request Mar 16, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
derrickstolee added a commit that referenced this pull request May 17, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
derrickstolee added a commit that referenced this pull request May 17, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
derrickstolee added a commit that referenced this pull request May 17, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
dscho pushed a commit that referenced this pull request May 21, 2021
This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of #304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants