Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar should use Git's background maintenance (drop Scalar.Service from Windows) #474

Closed
2 of 4 tasks
derrickstolee opened this issue Jan 11, 2021 · 4 comments
Closed
2 of 4 tasks
Assignees
Labels
platform:windows Affects Windows only polish

Comments

@derrickstolee
Copy link
Contributor

derrickstolee commented Jan 11, 2021

With background maintenance incorporated into Git, we should be able to drop the Service projects from Scalar entirely now.

I attempted this briefly in #472, but there are some subtleties regarding the installation process that I didn't have time to focus on.

Here is a rough outline of the work involved:

  1. Bring in the commits from Include Windows-specific maintenance and headless-git git-for-windows/git#2974 into microsoft/git (similar to Maintenance: create headless-git.exe to avoid foreground windows git#304)
  2. Update ConfigStep to run git maintenance start on all platforms.
  3. Delete service code from Windows platform.
  4. Ensure that the post-install steps run the config step on every registered repo.
@derrickstolee derrickstolee added platform:windows Affects Windows only polish labels Jan 11, 2021
@derrickstolee derrickstolee self-assigned this Jan 26, 2021
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Apr 26, 2021
@derrickstolee derrickstolee removed the no-activity Stale issue or PR that will be automatically closed soon. label Apr 26, 2021
@dscho
Copy link
Member

dscho commented Apr 28, 2021

Depending on how quickly I get the C port done, this might soon actually be quite pressing: how would we upgrade users transparently? Upon installation of the contrib/scalar-based Git, run an "upgrade" verb (to be implemented)? But that would potentially run into trouble when users might want to downgrade to .NET-based Scalar e.g. because they have to work around a bug in the new Scalar...

@derrickstolee
Copy link
Contributor Author

We are intending to use the git upgrade-microsoft-git functionality (which is not yet renamed from git upgrade-git-for-windows).

I don't think we should worry about users wanting to downgrade to the .NET version, because we won't ship it until we are comfortable with it. We will transition users to it slowly.

If a user does need to change versions, then the only way to do so will be to manually uninstall one version and then manually install the other as downloaded from the GitHub releases page.

@derrickstolee
Copy link
Contributor Author

Closing this because the Scalar CLI in microsoft/git does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows Affects Windows only polish
Projects
None yet
Development

No branches or pull requests

2 participants