-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut over to the new spec authoring platform #3094
Conversation
e0032ef
to
f0398e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great on the whole. Just a bunch of little fixes and suggestions below.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@@ -337,7 +337,7 @@ func (s *server) serveSpec(w http.ResponseWriter, req *http.Request) { | |||
log.Printf("Serving pr %s (%s)\n", branchName, sha) | |||
} else if strings.ToLower(branchName) == "head" || | |||
branchName == "master" || | |||
strings.HasPrefix(branchName, "drafts/") { | |||
strings.HasPrefix(branchName, "attic/drafts/") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctrl+f for the win
Cut over to the new spec authoring platform
Cut over to the new spec authoring platform
Should check off enough of #3055 to unfreeze. Incorporates much of #3025, though we may still want to look at #3025 for supplemental documentation.
In collaboration with matrix-org/matrix.org#970
Reviewer: The commits are largely isolated and have a bit of a story progression to them. This isn't a perfect cleanup, but it should be enough to continue spec writing.
The CI is not transitioned fully here, but the now-wasted bytes from the bundle are removed.