Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity service versions API #3101

Merged
merged 5 commits into from
May 4, 2021

Conversation

turt2live
Copy link
Member

Specs MSC2320
Built upon #3094

See pull/3094/head...pull/3101/head for the real diff

@turt2live turt2live requested a review from a team April 6, 2021 02:47
@anoadragon453 anoadragon453 self-requested a review April 6, 2021 15:40
swagger: '2.0'
info:
title: "Matrix Identity Service Versions API"
version: "1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that really the right version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically yes - this is the endpoint version rather than the spec version

@turt2live turt2live requested a review from anoadragon453 May 2, 2021 06:14
@turt2live
Copy link
Member Author

@anoadragon453 please take a quick look at the latest commits. I've completely destroyed the ability to use the diff views though, sorry.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a couple nits.

description: |-
Gets the versions of the specification supported by the server.

Values will take the form `rX.Y.Z`. <!-- TODO: TravisR: Global versioning spec -->
Copy link
Member

@anoadragon453 anoadragon453 May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<!-- TODO: TravisR: Global versioning spec -->

I assume you meant to leave this in, though I don't see this anywhere else in the spec as of yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is to remind me there's more than just a client server API

data/api/identity/versions.yaml Outdated Show resolved Hide resolved
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@turt2live turt2live merged commit f27b8e3 into master May 4, 2021
@turt2live turt2live deleted the travis/spec/MSC2320-identity-versions branch May 4, 2021 15:26
richvdh pushed a commit that referenced this pull request Aug 23, 2021
…-versions

Add identity service versions API
richvdh pushed a commit that referenced this pull request Aug 27, 2021
…-versions

Add identity service versions API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants