-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identity service versions API #3101
Conversation
swagger: '2.0' | ||
info: | ||
title: "Matrix Identity Service Versions API" | ||
version: "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that really the right version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically yes - this is the endpoint version rather than the spec version
@anoadragon453 please take a quick look at the latest commits. I've completely destroyed the ability to use the diff views though, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just a couple nits.
description: |- | ||
Gets the versions of the specification supported by the server. | ||
|
||
Values will take the form `rX.Y.Z`. <!-- TODO: TravisR: Global versioning spec --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- TODO: TravisR: Global versioning spec -->
I assume you meant to leave this in, though I don't see this anywhere else in the spec as of yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is to remind me there's more than just a client server API
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
…-versions Add identity service versions API
…-versions Add identity service versions API
Specs MSC2320
Built upon #3094
See pull/3094/head...pull/3101/head for the real diff