-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2320: Versions information for identity servers #2320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing to consider would be whether or not we actually need this yet on the identity API.
The current plan about MSC2265 is to start implement it as an unstable/experimental feature before the MSC is merged because the general opinion is that it's not going to change (or not much) til then. This means that identity servers need to be able to tell clients to case fold email addresses before computing hashes, otherwise email lookups will break, thus this is something we need before being able to ship an implementation (especially the advertisement of unstable features). |
concerns should have been addressed
Concerns should have been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review status for posterity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems straightforward now - thanks!
I think this is small and ready enough to pass through the phases. I don't think this needs an implementation proof given its size and scope. @mscbot fcp merge |
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Merged 🎉 |
MSC2320: Versions information for identity servers
MSC2320: Versions information for identity servers
Rendered