Spec spoilers and color attribute allowance #2549
Conversation
| The plain text (``body``) fallback for spoilers is a little different than the HTML-formatted | ||
| message as the ``body`` is often included as-is in notifications to the user. To prevent spoilers | ||
| in notifications and other places, clients are strongly encouraged to first upload the spoiler |
There was a problem hiding this comment.
| The plain text (``body``) fallback for spoilers is a little different than the HTML-formatted | |
| message as the ``body`` is often included as-is in notifications to the user. To prevent spoilers | |
| in notifications and other places, clients are strongly encouraged to first upload the spoiler | |
| When sending a spoiler, clients SHOULD provide the plain text fallback in ``body``. | |
| The fallback SHOULD omit the spoiler text verbatim (but include the reason), since ``body`` | |
| contents can be used as-is in basic clients, notifications to the user etc. To prevent spoilers | |
| showing up in such situations, clients are strongly encouraged to first upload the spoiler |
There was a problem hiding this comment.
The MSC does not make the fallback a SHOULD, anywhere (or I'm failing to see it). The MSC only ever references it as "the plaintext fallback" in a context of SHOULD upload the text, implying that it is required (in terms of language on the page).
To be clear, this concern is about the first SHOULD - the second SHOULD with respect to uploading the files is fine.
I'm happy to block this PR behind another MSC to clarify the intent, as this seems like it could be an opportunity for extended discussion which doesn't belong here.
There was a problem hiding this comment.
Yeah, I agree the original MSC is not perfectly clear on the modality of the fallback (whether it's SHOULD or MUST).
There was a problem hiding this comment.
Soru intended to word it as a recommendation, however if it is ambiguous it seems like further discussion might be appropriate.
Co-authored-by: Kitsune Ral <Kitsune-Ral@users.sf.net>
| @@ -499,6 +499,54 @@ the output looks similar to the following:: | |||
| For ``m.image``, the text should be ``"sent an image."``. For ``m.video``, the text | |||
| should be ``"sent a video."``. For ``m.audio``, the text should be ``"sent an audio file"``. | |||
|
|
|||
| Spoiler messages | |||
There was a problem hiding this comment.
TODO: Mention that spoilers are only possible on m.room.message (specifically m.text) events.
If another MSC does show up, it'd be good to expand this to textual types in general (emotes, notices, etc).
turt2live
added
the
blocked
|
this is unblocked now, but needs to be reviewed for accuracy before going back to general spec review. |
|
also needs to be ported to the markdown version |
|
Replaced by #3098 |
Spoilers MSC: #2010
colorattribute MSC: #2422